(test) O3-2081: Fix tests for the PatientRegistration component
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piumal1999
reviewed
Jun 8, 2023
packages/esm-patient-registration-app/src/patient-registration/patient-registration.test.tsx
Show resolved
Hide resolved
|
@Piumal1999 @jayasanka-sack @Anjula I was able to fix the failing test and also created two separate describes for the edit and registering a patient please check. |
anjula-sack
reviewed
Jun 19, 2023
packages/esm-patient-registration-app/src/patient-registration/patient-registration.test.tsx
Show resolved
Hide resolved
denniskigen
changed the title
PatientRegistration component
denniskigen
changed the title
PatientRegistration componentPatientRegistration component
Piumal1999
reviewed
Jun 20, 2023
packages/esm-patient-registration-app/src/patient-registration/patient-registration.test.tsx
Outdated
Show resolved
Hide resolved
|
There are still a whole bunch of warnings in the test output. It'd be great if we could address that @anjula-sack @ayush-AI. |
denniskigen
reviewed
Jun 20, 2023
| @@ -1,9 +1,9 @@ | |||
| import React from 'react'; | |||
| import { BrowserRouter as Router } from 'react-router-dom'; | |||
| import { BrowserRouter as Router, useParams } from 'react-router-dom'; | |||
| import { render, screen, fireEvent, waitFor, within } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Here and elsewhere, we should use either fireEvent or useEvent. Not both.
There was a problem hiding this comment.
done. Please check
Piumal1999
reviewed
Jun 20, 2023
packages/esm-patient-registration-app/src/patient-registration/patient-registration.test.tsx
Outdated
Show resolved
Hide resolved
|
In this PR I have removed some unwanted test from the input.test.tsx file. These test were not need as these test doesn't coincide with the actual implementation of the input.component.tsx. |
ayush-AI
force-pushed
the
patient-registration
branch
from
d1d9a20
to
2d4786b
Compare
anjula-sack
approved these changes
Jul 3, 2023
anjula-sack
requested changes
Jul 3, 2023
…-management into patient-registration
…m-patient-management into patient-registration
anjula-sack
previously requested changes
Jul 4, 2023
packages/esm-patient-registration-app/src/patient-registration/patient-registration.test.tsx
Outdated
Show resolved
Hide resolved
…-management into patient-registration
Piumal1999
reviewed
Jul 17, 2023
...es/esm-patient-registration-app/src/patient-registration/field/name/name-field.component.tsx
Outdated
Show resolved
Hide resolved
...esm-patient-registration-app/src/patient-registration/input/basic-input/input/input.test.tsx
Show resolved
Hide resolved
packages/esm-patient-registration-app/src/patient-registration/patient-registration.test.tsx
Outdated
Show resolved
Hide resolved
…-management into patient-registration
ayush-AI
force-pushed
the
patient-registration
branch
from
7dd10fc
to
5518fa5
Compare
…-management into patient-registration
Piumal1999
approved these changes
Aug 10, 2023
Piumal1999
requested review from
anjula-sack
and removed request for
anjula-sack
|
Hi @anjula-sack , Could you please review and merge it? It seems like I don't have permission to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
In this PR, I fixed all the failing test cases for patient-registation.test.tsx file. There were multiple tests failing due to multiple reasons. I addressed those issues and now all the tests are passing except this one. I have added necessary comments why the test is failing and also commented the approaches that I took in attempt to fix the issue, but the test is still failing.
Screenshots
None.
Related Issue
https://issues.openmrs.org/browse/O3-2082
Other
Please look into the failing test and suggest some ways to fix it.
None.