(feat) O3-2100: Unknown patient name and estimated D.O.B config #697

Jexsie · 2023-05-15T09:51:45Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
I checked for feature overlap with existing widgets.

Summary

This PR introduces the allowing/ restricting of registering unidentified patients and patients with estimated date of birth using the configuration.

The new configuration points added are:

{
  "@openmrs/esm-patient-registration-app": {
    "fieldConfigurations": {
      "name": {
        "allowUnidentifiedPatients": true,
        ...
      },
      "dateOfBirth": {
        "allowEstimatedDateOfBirth": true
        ...
      }
    }
  }
}

Screenshots

None.

Related Issue

https://issues.openmrs.org/browse/O3-2100

Other

None.

...es/esm-patient-registration-app/src/patient-registration/field/name/name-field.component.tsx

ibacher

A few small things I noticed reading through this.

packages/esm-patient-registration-app/src/config-schema.ts

packages/esm-patient-registration-app/src/patient-registration/field/dob/dob.component.tsx

...es/esm-patient-registration-app/src/patient-registration/field/name/name-field.component.tsx

packages/esm-patient-registration-app/src/patient-registration/form-manager.test.ts

...ages/esm-patient-registration-app/src/patient-registration/patient-registration.resource.tsx

vasharma05 · 2023-05-25T09:45:08Z

Hi @ibacher !
For the estimated birthdates, the FHIR APIs only return the estimated year of birth and not the month of birth, even though we send the estimated dob to the backend.

packages/esm-patient-registration-app/src/config-schema.ts

…management into name

ibacher · 2023-05-25T11:01:20Z

For the estimated birthdates, the FHIR APIs only return the estimated year of birth and not the month of birth, even though we send the estimated dob to the backend.

It’s slightly more complicated than that. For patients 5 and under, it will return the year + month. But anyone six or older it just sends the year. This is because the WHO guidelines for children are broken down by month(s) for children up to 5 years of age. Past that, it’s an estimated birthdate, so including other date parts gives false precision (technically, we always store a full date).

From a user perspective, I wouldn’t expect anyone to estimate an age as “30 years and 2 months”. The “2 months” are very unlikely to be clinically significant. However, for toddlers, infants, and newborns, 2 months can very clinically significant, so we return that data.

vasharma05 · 2023-05-25T12:55:28Z

This clears a lot.
Thanks @ibacher !

ibacher · 2023-05-25T12:58:11Z

I'm actually surprised no one had asked about that before...

ibacher

Looks like this is in good shape to me. A few comments / questions to make sure we're adhering to requirements.

packages/esm-patient-registration-app/src/config-schema.ts

ibacher · 2023-06-15T12:17:25Z

packages/esm-patient-registration-app/src/patient-registration/field/dob/dob.component.tsx

@@ -25,7 +25,8 @@ export const DobField: React.FC = () => {
  const { t } = useTranslation();
  const {
    fieldConfigurations: { dateOfBirth },
-  } = useConfig() as RegistrationConfig;
+  } = useConfig<RegistrationConfig>();
+  const allowEstimatedBirthDate = dateOfBirth?.allowEstimatedDateOfBirth;
  const [dobUnknown] = useField('birthdateEstimated');
  const dobKnown = !dobUnknown.value;


It's a little weird to create a variable which is !dobUnknown.value and then use it as !dobKnown. It might read more clearly just to have dobUnknown.value in the OR, no?

Can this be addressed?

packages/esm-patient-registration-app/src/config-schema.ts

packages/esm-patient-registration-app/src/patient-registration/form-manager.ts

denniskigen · 2023-07-03T08:13:48Z

@Jexsie, could you respond to the comments raised in the PR review?

…ient-management into name

ibacher · 2023-07-11T12:37:36Z

Can we resolve the e2e tests? After that, this should be good to merge.

vasharma05 · 2023-07-11T19:03:22Z

Hi @ibacher !
I tried to fix the tests for the past 2 hours, but due to lack of knowledge, I am not able to fix it.
I request you to please let the PR be merged with the test, and I'll cover this test along with the tests related to patient management.
Thanks!

vasharma05 · 2023-07-11T19:05:48Z

This is required for Cambodia's latest server.
Can you please take the PR ahead for now?
Thanks!

ibacher · 2023-07-11T19:42:47Z

Can you please take the PR ahead for now?

So, one very small comment I had initially left; once that's addressed, I'm happy to merge this in and follow-up on the e2e tests later.

vasharma05 · 2023-07-11T19:49:28Z

I've made the requested changes @ibacher !

ibacher · 2023-07-11T19:51:34Z

Looks like a syntax error...

vasharma05 · 2023-07-11T19:51:50Z

Fixed the error @ibacher and tested the changes locally too.

…s#697) Co-authored-by: Vineet Sharma <[email protected]>

* added test for utils.ts * resolved review commits * (feat) Remove filtering todays queue entries on frontend (#752) * (refactor): Display all active visits by removing filter for showing only today's active visits (#755) * (refactor): changed activeVisits.idNumber assignment for improved code robustness (#756) * (feat) O3-2100: Unknown patient name and estimated DOB config (#697) Co-authored-by: Vineet Sharma <[email protected]> * (test) O3-2225/6: Add tests for cancel-patient-edit.component and delete-identifier-confirmation-modal (#750) * removed the extra types --------- Co-authored-by: Anjula Shanaka <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: CynthiaKamau <[email protected]> Co-authored-by: Donald Kibet <[email protected]> Co-authored-by: Jexsie <[email protected]> Co-authored-by: Vineet Sharma <[email protected]>

…s#697) Co-authored-by: Vineet Sharma <[email protected]>

* added test for utils.ts * resolved review commits * (feat) Remove filtering todays queue entries on frontend (openmrs#752) * (refactor): Display all active visits by removing filter for showing only today's active visits (openmrs#755) * (refactor): changed activeVisits.idNumber assignment for improved code robustness (openmrs#756) * (feat) O3-2100: Unknown patient name and estimated DOB config (openmrs#697) Co-authored-by: Vineet Sharma <[email protected]> * (test) O3-2225/6: Add tests for cancel-patient-edit.component and delete-identifier-confirmation-modal (openmrs#750) * removed the extra types --------- Co-authored-by: Anjula Shanaka <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: CynthiaKamau <[email protected]> Co-authored-by: Donald Kibet <[email protected]> Co-authored-by: Jexsie <[email protected]> Co-authored-by: Vineet Sharma <[email protected]>

mseaton reviewed May 15, 2023

View reviewed changes

...es/esm-patient-registration-app/src/patient-registration/field/name/name-field.component.tsx Show resolved Hide resolved

Jexsie force-pushed the name branch 2 times, most recently from d1f9b0a to 14d22a7 Compare May 15, 2023 16:25

Jexsie requested a review from mseaton May 15, 2023 16:34

Jexsie force-pushed the name branch 3 times, most recently from c882b5b to ad533c3 Compare May 17, 2023 07:48

Jexsie commented May 17, 2023

View reviewed changes

...es/esm-patient-registration-app/src/patient-registration/field/name/name-field.component.tsx Outdated Show resolved Hide resolved

vasharma05 changed the title ~~(fix) O3-2100: Unkown patient name and estimated D.O.B config~~ (fix) O3-2100: Unknown patient name and estimated D.O.B config May 17, 2023

(fix) unkown patient name and estimated dob config fix

577e366

jayasanka-sack force-pushed the name branch from ad533c3 to 577e366 Compare May 17, 2023 16:01

Jexsie added 2 commits May 22, 2023 14:22

Merge branch 'main' into name

c138e52

Merge branch 'main' into name

c776b59

makombe mentioned this pull request May 23, 2023

(feat) Add configuration for patient name known toggle #708

Closed

3 tasks

Updated config schema for updation in config point for unknown name

c1f33c7

vasharma05 marked this pull request as draft May 24, 2023 15:17

Made the attribute Unknown patient as the only source of truth

c8bff81

vasharma05 requested review from denniskigen and ibacher May 24, 2023 15:32

ibacher requested changes May 24, 2023

View reviewed changes

BirthdateEstimation configuration added

edccc2c

vasharma05 reviewed May 25, 2023

View reviewed changes

packages/esm-patient-registration-app/src/config-schema.ts Outdated Show resolved Hide resolved

vasharma05 added 3 commits May 25, 2023 15:32

Fixed type

64f7f3b

Merge branch 'name' of https://github.com/Jexsie/openmrs-esm-patient-…

0f53971

…management into name

Review changes

6b8e163

vasharma05 changed the title ~~(fix) O3-2100: Unknown patient name and estimated D.O.B config~~ (feat) O3-2100: Unknown patient name and estimated D.O.B config May 30, 2023

Fixed failing test

e8d2b6f

vasharma05 requested a review from ibacher May 30, 2023 08:00

Merge branch 'main' into name

723d103

ibacher reviewed Jun 15, 2023

View reviewed changes

vasharma05 added 5 commits July 7, 2023 11:54

Merge branch 'main' of https://www.github.com/openmrs/openmrs-esm-pat…

e156422

…ient-management into name

Review changes

5fae7e6

Update config-schema.ts

686e76d

Update config-schema.ts

7bb8228

Merge branch 'main' into name

535d160

vasharma05 requested a review from ibacher July 9, 2023 12:31

Merge branch 'main' into name

e8a19b0

vasharma05 added 2 commits July 12, 2023 01:16

Review changes

25f8f0d

Fix

913a326

ibacher approved these changes Jul 11, 2023

View reviewed changes

Update dob.component.tsx

27e490d

vasharma05 added 2 commits July 12, 2023 01:24

Lint fixes

379f1d0

Merge branch 'main' into name

5e4094e

ibacher merged commit 7dbf922 into openmrs:main Jul 11, 2023
6 of 7 checks passed

ayush-AI pushed a commit to ayush-AI/openmrs-esm-patient-management that referenced this pull request Jul 13, 2023

(feat) O3-2100: Unknown patient name and estimated DOB config (openmr…

330d73e

…s#697) Co-authored-by: Vineet Sharma <[email protected]>

ayush-AI pushed a commit to ayush-AI/openmrs-esm-patient-management that referenced this pull request Jul 13, 2023

(feat) O3-2100: Unknown patient name and estimated DOB config (openmr…

711c312

…s#697) Co-authored-by: Vineet Sharma <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(feat) O3-2100: Unknown patient name and estimated D.O.B config #697

(feat) O3-2100: Unknown patient name and estimated D.O.B config #697

Jexsie commented May 15, 2023 •

edited by vasharma05

Loading

ibacher left a comment

vasharma05 commented May 25, 2023

ibacher commented May 25, 2023

vasharma05 commented May 25, 2023

ibacher commented May 25, 2023

ibacher left a comment

ibacher Jun 15, 2023

ibacher Jul 11, 2023

denniskigen commented Jul 3, 2023

ibacher commented Jul 11, 2023 •

edited

Loading

vasharma05 commented Jul 11, 2023

vasharma05 commented Jul 11, 2023

ibacher commented Jul 11, 2023

vasharma05 commented Jul 11, 2023

ibacher commented Jul 11, 2023 •

edited

Loading

vasharma05 commented Jul 11, 2023 •

edited

Loading

(feat) O3-2100: Unknown patient name and estimated D.O.B config #697

(feat) O3-2100: Unknown patient name and estimated D.O.B config #697

Conversation

Jexsie commented May 15, 2023 • edited by vasharma05 Loading

Requirements

Summary

Screenshots

Related Issue

Other

ibacher left a comment

Choose a reason for hiding this comment

vasharma05 commented May 25, 2023

ibacher commented May 25, 2023

vasharma05 commented May 25, 2023

ibacher commented May 25, 2023

ibacher left a comment

Choose a reason for hiding this comment

ibacher Jun 15, 2023

Choose a reason for hiding this comment

ibacher Jul 11, 2023

Choose a reason for hiding this comment

denniskigen commented Jul 3, 2023

ibacher commented Jul 11, 2023 • edited Loading

vasharma05 commented Jul 11, 2023

vasharma05 commented Jul 11, 2023

ibacher commented Jul 11, 2023

vasharma05 commented Jul 11, 2023

ibacher commented Jul 11, 2023 • edited Loading

vasharma05 commented Jul 11, 2023 • edited Loading

Jexsie commented May 15, 2023 •

edited by vasharma05

Loading

ibacher commented Jul 11, 2023 •

edited

Loading

ibacher commented Jul 11, 2023 •

edited

Loading

vasharma05 commented Jul 11, 2023 •

edited

Loading