(fix) - O3-4017 - Ward App - ward view should refresh data after actions on patients #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
requested review from
mseaton,
mogoodrich,
vasharma05 and
usamaidrsk
|
Size Change: +1.02 kB (+0.02%) Total Size: 6.1 MB ℹ️ View Unchanged
|
mogoodrich
approved these changes
Sep 30, 2024
| @@ -20,7 +19,8 @@ export default function PatientDischargeWorkspace(props: WardPatientWorkspacePro | |||
| const { emrConfiguration, isLoadingEmrConfiguration, errorFetchingEmrConfiguration } = useEmrConfiguration(); | |||
| const wardGroupingDetails = useAppContext<WardPatientGroupDetails>('ward-patients-group'); | |||
| const { mutate: mutateAdmissionLocation } = wardGroupingDetails?.admissionLocationResponse ?? {}; | |||
| const { mutate: mutateInpatientRequest } = useInpatientRequest(); | |||
| const { mutate: mutateInpatientRequest } = wardGroupingDetails?.inpatientRequestResponse ?? {}; | |||
| const { mutate: mutateInpatientAdmission } = wardGroupingDetails?.inpatientAdmissionResponse ?? {}; | |||
There was a problem hiding this comment.
Just curious, were these functions just not properly getting pulled in before?
|
@chibongho do we need to ping others for a review of this? |
|
Oh shoot... forgot about this PR. I'll just merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes the following:
The root cause is mostly from not calling the right mutate functions after those actions. Calling the right mutate functions in most cases fixed this.
I also refactored most places to not call
inpatientRequests,inpatientAdmissionandadmissionLocationendpoints directly, and instead rely on the results of those calls already stored inuseAppContext().Also cleaned up some of our unit tests to have consolidate mocked hooks.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4017
Other