-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3737: Fix pending items configuration on ward patient card #1324
Conversation
Size Change: -69.2 kB (-1.12%) Total Size: 6.1 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. Looks good otherwise.
}, [orders]); | ||
|
||
return ( | ||
<div className={styles.wardPatientCardPendingItemsRow}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this leave a visibly empty div row when there are no pending items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really @chibongho ,
.wardPatientCardPendingItemsRow:empty {
display: none;
margin-left: layout.$spacing-04;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good then. Thanks!
Requirements
Summary
This PR fixed the pending items configuration of the pending card, before the pending items count was showing only if there was an inpatient-request.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3737
Other