(fix) O3-3915: The buttons in the refine-search overlay for the patient search button are partially hidden in a desktop layout #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
LGTM. Eventually we want to move the patient search over to using the workspace system. Thanks for the bug ticket & fix @mccarthyaaron .
brandones
changed the title
You are welcome @brandones . Concerning moving it to using the workspace system is there any ongoing work or discussion about it? and if so where can one follow it from |
|
Great question @mccarthyaaron , I should have linked the ticket before. Here it is: https://openmrs.atlassian.net/browse/O3-3326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR addresses an issue in the refine search overlay component under the patient search. On desktop the buttons for submitting or discarding the refined search are partially hidden.
This seems to be caused by the fact that the
Overlaycomponent here has a height of 100vh as well as a position from the top of 3rem. This causes it to immediately go below the viewport. The actual issue then seems to arise down the component hierarchy here with the refine seach dialog container. It is positionedbottom: 0(which bottom is below the screen). Couple that with thejustify-content: flex-endand you then end up with the the containers content partially hidden below the viewport.the suggested solution here is to remove the height property from the Overlay component and give it
bottom: 0. Such that it sticks to the bottom of the viewport.Screenshots
refine-fix.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-3915