(fix) O3-3906: ComposedModal usage missing scroll bar #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chibongho @vasharma05 @usamaidrsk could you please review this PR, your feedback will be appreciated. |
usamaidrsk
requested review from
brandones,
chibongho,
vasharma05 and
usamaidrsk
denniskigen
reviewed
Sep 9, 2024
packages/esm-bed-management-app/src/bed-tag/bed-tags-admin-form.component.tsx
Show resolved
Hide resolved
packages/esm-bed-management-app/src/bed-type/bed-type-admin-form.component.tsx
Show resolved
Hide resolved
IamMujuziMoses
force-pushed
the
O3-3906
branch
from
e4e3e67
to
d861aba
Compare
denniskigen
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently, using of ComposedModal in the Bed management module is missing a scroll bar, this PR adds a Scrollbar to the dialog to make it easy for different screen sizes.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-3906