Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat) O3-3348: Allow Checking in to appointments even if there's already an active v… #1304

Closed
wants to merge 2 commits into from

Conversation

lucyjemutai
Copy link
Contributor

…isit

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

https://openmrs.atlassian.net/browse/O3-3348

I refactored the CheckInButton component to simplify logic and support showing the button even with an active visit, based on a config option. This eliminates the need for a custom check-in form.

Screenshots

Related Issue

Other

@lucyjemutai
Copy link
Contributor Author

The changes don't introduce any visible differences on the UI. The work had been partially done -->#1165

@lucyjemutai lucyjemutai marked this pull request as ready for review September 3, 2024 08:45
@mogoodrich
Copy link
Member

Thanks @lucyjemutai ! Let me refresh my memory on this ticket and then I will review...

@mogoodrich
Copy link
Member

@lucyjemutai can you remind me where this appears in the UI?

@lucyjemutai
Copy link
Contributor Author

@mogoodrich So, this ticket was to allow the check in even when a patient has active visit. . The work had been partially done and for this pr there is no visible differences on the UI.

@ojwanganto
Copy link
Contributor

@mogoodrich So, this ticket was to allow the check in even when a patient has active visit. . The work had been partially done and for this pr there is no visible differences on the UI.

I thought it is the check-in process that starts a visit. How then do we have check-in for already checked in patients?

@mogoodrich
Copy link
Member

Thanks @lucyjemutai ! I'm a little underwater now with work right now and need to refresh my memory on my initial requirements for this, but I hope to get to it soon.

@mogoodrich
Copy link
Member

@lucyjemutai, unfortunately. I don't think we are ready for this yet, I have have updated the ticket with more thoughts on the design. Not sure if this is a priority for others, we (PIH) have served our use case by creating a custom HTML Form Entry check-in form). I am going to close this out, but thanks so much!

@mogoodrich mogoodrich closed this Sep 13, 2024
@lucyjemutai
Copy link
Contributor Author

@mogoodrich Noted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants