Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Update Carbon styling import paths and tokens #1281

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Aug 13, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR refactors the styling of components in the Patient Chart to enhance maintainability, consistency and future compatibility with the Carbon Design System. Key changes include:

  • Switching import paths to consolidated packages for color, type and spacing tokens from Carbon. This approach seems more future-proof and encourages consistency across the codebase.
  • Replacing hardcoded CSS spacing values with their Carbon equivalents.
  • Switching from the @import directive to @use for importing variables to enhance encapsulation and avoid naming conflicts:
    • @import adds everything to the global scope, while @use keeps imports modular by default, preventing naming conflicts.
    • @use includes the file only once, even if used multiple times, improving performance.
    • @use aligns with modern Sass best practices and is more future-proof.
  • Removing unnecessary root.scss files.

Screenshots

Related Issue

Other

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Size Change: -138 kB (-2.31%)

Total Size: 5.82 MB

Filename Size Change
packages/esm-patient-list-management-app/dist/112.js 63 kB -10.3 kB (-14.06%) 👏
packages/esm-patient-list-management-app/dist/main.js 167 kB -10.2 kB (-5.77%)
packages/esm-patient-registration-app/dist/540.js 67.4 kB -17.7 kB (-20.77%) 🎉
packages/esm-patient-registration-app/dist/main.js 131 kB -17.6 kB (-11.83%) 👏
packages/esm-patient-search-app/dist/634.js 51.9 kB -23.2 kB (-30.9%) 🎉
packages/esm-patient-search-app/dist/main.js 77.4 kB -23.2 kB (-23.06%) 🎉
ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/106.js 8.63 kB 0 B
packages/esm-active-visits-app/dist/130.js 317 kB 0 B
packages/esm-active-visits-app/dist/255.js 2.5 kB 0 B
packages/esm-active-visits-app/dist/271.js 800 B 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 709 B 0 B
packages/esm-active-visits-app/dist/382.js 1.22 kB 0 B
packages/esm-active-visits-app/dist/443.js 6.98 kB 0 B
packages/esm-active-visits-app/dist/460.js 824 B 0 B
packages/esm-active-visits-app/dist/574.js 615 B 0 B
packages/esm-active-visits-app/dist/6.js 26.2 kB -689 B (-2.56%)
packages/esm-active-visits-app/dist/635.js 1.22 kB 0 B
packages/esm-active-visits-app/dist/644.js 800 B 0 B
packages/esm-active-visits-app/dist/725.js 632 B 0 B
packages/esm-active-visits-app/dist/729.js 3.08 kB 0 B
packages/esm-active-visits-app/dist/757.js 721 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 628 B 0 B
packages/esm-active-visits-app/dist/807.js 959 B 0 B
packages/esm-active-visits-app/dist/833.js 765 B 0 B
packages/esm-active-visits-app/dist/879.js 3.02 kB 0 B
packages/esm-active-visits-app/dist/966.js 51.3 kB 0 B
packages/esm-active-visits-app/dist/967.js 600 B 0 B
packages/esm-active-visits-app/dist/main.js 81.9 kB -732 B (-0.89%)
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.33 kB 0 B
packages/esm-appointments-app/dist/130.js 317 kB 0 B
packages/esm-appointments-app/dist/152.js 259 B 0 B
packages/esm-appointments-app/dist/23.js 14.4 kB 0 B
packages/esm-appointments-app/dist/255.js 2.51 kB 0 B
packages/esm-appointments-app/dist/265.js 1.79 kB 0 B
packages/esm-appointments-app/dist/271.js 2.32 kB 0 B
packages/esm-appointments-app/dist/303.js 259 B 0 B
packages/esm-appointments-app/dist/319.js 2.15 kB 0 B
packages/esm-appointments-app/dist/460.js 2.37 kB 0 B
packages/esm-appointments-app/dist/501.js 7.02 kB 0 B
packages/esm-appointments-app/dist/574.js 1.94 kB 0 B
packages/esm-appointments-app/dist/581.js 9.03 kB 0 B
packages/esm-appointments-app/dist/591.js 16.8 kB 0 B
packages/esm-appointments-app/dist/644.js 2.32 kB 0 B
packages/esm-appointments-app/dist/646.js 250 kB 0 B
packages/esm-appointments-app/dist/729.js 3.08 kB 0 B
packages/esm-appointments-app/dist/757.js 2.21 kB 0 B
packages/esm-appointments-app/dist/784.js 2.62 kB 0 B
packages/esm-appointments-app/dist/788.js 1.94 kB 0 B
packages/esm-appointments-app/dist/807.js 2.56 kB 0 B
packages/esm-appointments-app/dist/833.js 2.3 kB 0 B
packages/esm-appointments-app/dist/85.js 30.5 kB 0 B
packages/esm-appointments-app/dist/89.js 138 kB -5.71 kB (-3.98%)
packages/esm-appointments-app/dist/903.js 879 B 0 B
packages/esm-appointments-app/dist/main.js 405 kB -5.1 kB (-1.24%)
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.39 kB 0 B
packages/esm-bed-management-app/dist/130.js 317 kB 0 B
packages/esm-bed-management-app/dist/148.js 1.22 kB 0 B
packages/esm-bed-management-app/dist/169.js 6.98 kB 0 B
packages/esm-bed-management-app/dist/271.js 680 B 0 B
packages/esm-bed-management-app/dist/319.js 680 B 0 B
packages/esm-bed-management-app/dist/460.js 680 B 0 B
packages/esm-bed-management-app/dist/501.js 7.03 kB 0 B
packages/esm-bed-management-app/dist/542.js 395 B 0 B
packages/esm-bed-management-app/dist/574.js 681 B 0 B
packages/esm-bed-management-app/dist/591.js 16.8 kB 0 B
packages/esm-bed-management-app/dist/644.js 680 B 0 B
packages/esm-bed-management-app/dist/668.js 26.5 kB 0 B
packages/esm-bed-management-app/dist/729.js 3.08 kB 0 B
packages/esm-bed-management-app/dist/757.js 731 B 0 B
packages/esm-bed-management-app/dist/766.js 113 kB 0 B
packages/esm-bed-management-app/dist/784.js 2.63 kB 0 B
packages/esm-bed-management-app/dist/788.js 680 B 0 B
packages/esm-bed-management-app/dist/805.js 50.2 kB +650 B (+1.31%)
packages/esm-bed-management-app/dist/807.js 680 B 0 B
packages/esm-bed-management-app/dist/833.js 680 B 0 B
packages/esm-bed-management-app/dist/main.js 3.87 kB 0 B
packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js 3.25 kB 0 B
packages/esm-patient-list-management-app/dist/130.js 317 kB 0 B
packages/esm-patient-list-management-app/dist/255.js 2.51 kB 0 B
packages/esm-patient-list-management-app/dist/271.js 99.8 kB 0 B
packages/esm-patient-list-management-app/dist/319.js 1.51 kB 0 B
packages/esm-patient-list-management-app/dist/37.js 8.38 kB -1.11 kB (-11.7%) 👏
packages/esm-patient-list-management-app/dist/382.js 1.23 kB 0 B
packages/esm-patient-list-management-app/dist/384.js 1.58 kB 0 B
packages/esm-patient-list-management-app/dist/443.js 6.98 kB 0 B
packages/esm-patient-list-management-app/dist/460.js 1.72 kB 0 B
packages/esm-patient-list-management-app/dist/574.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-management-app/dist/635.js 1.23 kB 0 B
packages/esm-patient-list-management-app/dist/644.js 1.58 kB 0 B
packages/esm-patient-list-management-app/dist/729.js 3.08 kB 0 B
packages/esm-patient-list-management-app/dist/757.js 1.58 kB 0 B
packages/esm-patient-list-management-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-management-app/dist/788.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/807.js 1.85 kB 0 B
packages/esm-patient-list-management-app/dist/833.js 1.59 kB 0 B
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.31 kB 0 B
packages/esm-patient-registration-app/dist/130.js 317 kB 0 B
packages/esm-patient-registration-app/dist/152.js 264 B 0 B
packages/esm-patient-registration-app/dist/169.js 6.71 kB 0 B
packages/esm-patient-registration-app/dist/255.js 2.5 kB 0 B
packages/esm-patient-registration-app/dist/271.js 2.13 kB 0 B
packages/esm-patient-registration-app/dist/290.js 61.6 kB 0 B
packages/esm-patient-registration-app/dist/303.js 264 B 0 B
packages/esm-patient-registration-app/dist/319.js 2.05 kB 0 B
packages/esm-patient-registration-app/dist/371.js 547 B 0 B
packages/esm-patient-registration-app/dist/460.js 2.22 kB 0 B
packages/esm-patient-registration-app/dist/501.js 7.03 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.78 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-registration-app/dist/623.js 6.19 kB -1.55 kB (-20.06%) 🎉
packages/esm-patient-registration-app/dist/644.js 2.13 kB 0 B
packages/esm-patient-registration-app/dist/729.js 3.08 kB 0 B
packages/esm-patient-registration-app/dist/735.js 465 B 0 B
packages/esm-patient-registration-app/dist/757.js 2.15 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.78 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.51 kB 0 B
packages/esm-patient-registration-app/dist/833.js 2.06 kB 0 B
packages/esm-patient-registration-app/dist/879.js 3.03 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.35 kB 0 B
packages/esm-patient-search-app/dist/130.js 317 kB 0 B
packages/esm-patient-search-app/dist/255.js 2.5 kB 0 B
packages/esm-patient-search-app/dist/271.js 920 B 0 B
packages/esm-patient-search-app/dist/319.js 861 B 0 B
packages/esm-patient-search-app/dist/382.js 1.23 kB 0 B
packages/esm-patient-search-app/dist/420.js 22.4 kB 0 B
packages/esm-patient-search-app/dist/443.js 6.98 kB 0 B
packages/esm-patient-search-app/dist/460.js 939 B 0 B
packages/esm-patient-search-app/dist/574.js 742 B 0 B
packages/esm-patient-search-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-search-app/dist/635.js 1.23 kB 0 B
packages/esm-patient-search-app/dist/644.js 920 B 0 B
packages/esm-patient-search-app/dist/729.js 3.08 kB 0 B
packages/esm-patient-search-app/dist/757.js 871 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 736 B 0 B
packages/esm-patient-search-app/dist/807.js 1.04 kB 0 B
packages/esm-patient-search-app/dist/833.js 877 B 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.3 kB 0 B
packages/esm-service-queues-app/dist/130.js 317 kB 0 B
packages/esm-service-queues-app/dist/152.js 261 B 0 B
packages/esm-service-queues-app/dist/169.js 6.98 kB 0 B
packages/esm-service-queues-app/dist/186.js 0 B -8.99 kB (removed) 🏆
packages/esm-service-queues-app/dist/199.js 1.35 kB +1 B (+0.07%)
packages/esm-service-queues-app/dist/236.js 5.84 kB -10 B (-0.17%)
packages/esm-service-queues-app/dist/255.js 2.51 kB 0 B
packages/esm-service-queues-app/dist/265.js 118 kB -226 B (-0.19%)
packages/esm-service-queues-app/dist/271.js 4.56 kB 0 B
packages/esm-service-queues-app/dist/282.js 8.97 kB 0 B
packages/esm-service-queues-app/dist/303.js 261 B 0 B
packages/esm-service-queues-app/dist/319.js 3.86 kB 0 B
packages/esm-service-queues-app/dist/366.js 7.86 kB -12 B (-0.15%)
packages/esm-service-queues-app/dist/392.js 7.85 kB -13 B (-0.17%)
packages/esm-service-queues-app/dist/460.js 4.78 kB 0 B
packages/esm-service-queues-app/dist/484.js 158 kB 0 B
packages/esm-service-queues-app/dist/501.js 7.03 kB 0 B
packages/esm-service-queues-app/dist/574.js 3.85 kB 0 B
packages/esm-service-queues-app/dist/591.js 16.8 kB 0 B
packages/esm-service-queues-app/dist/6.js 1.75 kB 0 B
packages/esm-service-queues-app/dist/604.js 6.96 kB -16 B (-0.23%)
packages/esm-service-queues-app/dist/644.js 4.57 kB 0 B
packages/esm-service-queues-app/dist/670.js 10 kB -4 B (-0.04%)
packages/esm-service-queues-app/dist/727.js 8.1 kB -14 B (-0.17%)
packages/esm-service-queues-app/dist/729.js 3.08 kB 0 B
packages/esm-service-queues-app/dist/752.js 1.62 kB 0 B
packages/esm-service-queues-app/dist/757.js 4.14 kB 0 B
packages/esm-service-queues-app/dist/760.js 7.13 kB -15 B (-0.21%)
packages/esm-service-queues-app/dist/784.js 2.63 kB 0 B
packages/esm-service-queues-app/dist/788.js 3.86 kB 0 B
packages/esm-service-queues-app/dist/800.js 1.68 kB 0 B
packages/esm-service-queues-app/dist/807.js 5.14 kB 0 B
packages/esm-service-queues-app/dist/818.js 2.55 kB 0 B
packages/esm-service-queues-app/dist/828.js 1.39 kB 0 B
packages/esm-service-queues-app/dist/833.js 4.46 kB 0 B
packages/esm-service-queues-app/dist/911.js 7.76 kB -18 B (-0.23%)
packages/esm-service-queues-app/dist/940.js 21.4 kB 0 B
packages/esm-service-queues-app/dist/main.js 278 kB -238 B (-0.09%)
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.31 kB 0 B
packages/esm-ward-app/dist/130.js 317 kB 0 B
packages/esm-ward-app/dist/152.js 255 B 0 B
packages/esm-ward-app/dist/169.js 6.97 kB 0 B
packages/esm-ward-app/dist/255.js 2.5 kB 0 B
packages/esm-ward-app/dist/269.js 817 B 0 B
packages/esm-ward-app/dist/303.js 255 B 0 B
packages/esm-ward-app/dist/346.js 24.7 kB -22 B (-0.09%)
packages/esm-ward-app/dist/348.js 349 B 0 B
packages/esm-ward-app/dist/466.js 363 B 0 B
packages/esm-ward-app/dist/501.js 7.02 kB 0 B
packages/esm-ward-app/dist/574.js 1.28 kB 0 B
packages/esm-ward-app/dist/577.js 18 kB +24 B (+0.13%)
packages/esm-ward-app/dist/591.js 16.8 kB 0 B
packages/esm-ward-app/dist/659.js 9.78 kB -3.59 kB (-26.84%) 🎉
packages/esm-ward-app/dist/729.js 3.07 kB 0 B
packages/esm-ward-app/dist/749.js 8.12 kB -25 B (-0.31%)
packages/esm-ward-app/dist/76.js 4.96 kB -1 B (-0.02%)
packages/esm-ward-app/dist/767.js 648 B 0 B
packages/esm-ward-app/dist/784.js 2.62 kB 0 B
packages/esm-ward-app/dist/793.js 32.1 kB 0 B
packages/esm-ward-app/dist/803.js 13.8 kB -7.98 kB (-36.68%) 🎉
packages/esm-ward-app/dist/940.js 21.4 kB 0 B
packages/esm-ward-app/dist/960.js 342 B 0 B
packages/esm-ward-app/dist/main.js 59.9 kB -23 B (-0.04%)
packages/esm-ward-app/dist/openmrs-esm-ward-app.js 3.3 kB 0 B

compressed-size-action

@denniskigen denniskigen force-pushed the refactor/styling-imports-and-carbon-tokens branch from 8cd375a to 76be044 Compare August 13, 2024 22:32
@denniskigen denniskigen merged commit 7f570ca into main Aug 13, 2024
6 checks passed
@denniskigen denniskigen deleted the refactor/styling-imports-and-carbon-tokens branch August 13, 2024 22:45
@denniskigen denniskigen mentioned this pull request Aug 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants