-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) Update Carbon styling import paths and tokens #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -138 kB (-2.31%) Total Size: 5.82 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Aug 13, 2024
packages/esm-active-visits-app/src/active-visits-widget/active-visits.scss
Outdated
Show resolved
Hide resolved
denniskigen
force-pushed
the
refactor/styling-imports-and-carbon-tokens
branch
from
August 13, 2024 22:32
8cd375a
to
76be044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors the styling of components in the Patient Chart to enhance maintainability, consistency and future compatibility with the Carbon Design System. Key changes include:
@import
directive to@use
for importing variables to enhance encapsulation and avoid naming conflicts:@import
adds everything to the global scope, while@use
keeps imports modular by default, preventing naming conflicts.@use
includes the file only once, even if used multiple times, improving performance.@use
aligns with modern Sass best practices and is more future-proof.root.scss
files.Screenshots
Related Issue
Other