-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3242 - ward app - add admission request detail to admission… #1274
Conversation
Size Change: -30.1 kB (-0.5%) Total Size: 5.95 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, thanks @chibongho , see my one comment.
conceptUuid: { | ||
_type: Type.UUID, | ||
_description: 'Required. Identifies the concept for the admission request note.', | ||
_default: '161011AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sure what our best practices are for defaults, but I'm thinking we should only include a default if it's something in CIEL and included in the ref app. (which may be true for the above concept).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the bar for putting a default UUID seems to be whether it's included in the ref app.
In this case, the UUID is both in CIEL and in the ref app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me...
… request card
Requirements
Summary
This PR adds a row to Admission Request Cards to display the admission note. The row is added as an extension, while the actual element inside the row is the
WardPatientObs
, which is already implemented (for displaying the Gravita value).The default uuid for that row, "161011AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", is a valid concept in both refapp and PIH EMR. However, it seems to be a generic "Free text comment" concept. I'm not sure if I need to go further to limit this concept to the admission note that's submitted as part of the triage form. If there are multiple "Free text comment" obs collected, all of them would be displayed.
Screenshots
Related Issue
Other