Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3761: Add data-openmrs-role data attributes to DOM elements #1271

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

Vijaykv5
Copy link
Contributor

@Vijaykv5 Vijaykv5 commented Aug 7, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds data-openmrs-role to the DOM element in patient-search-app and patient-list-management-app

Screenshots

Related Issue

O3-3761

Other

cc : @jayasanka-sack

@denniskigen denniskigen changed the title (feat) O3-3761 : Add data-openmrs-role data attributes to DOM elements (feat) O3-3761: Add data-openmrs-role data attributes to DOM elements Aug 7, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, save for a typo

@@ -388,7 +388,7 @@ const ListDetailsTable: React.FC<ListDetailsTableProps> = ({
<>
<BackButton />
<Layer>
<Tile className={styles.tile}>
<Tile className={styles.tile} data-openmrs-role="Patient Emply tile">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dennis!

@denniskigen denniskigen merged commit d314437 into openmrs:main Aug 7, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request Aug 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants