(feat) O3-3604: Add notes history section on inpatient notes workspace #1269
Conversation
usamaidrsk
changed the title
There was a problem hiding this comment.
Thanks @usamaidrsk , generally looks good... just one question about passing the config as a prop instead of fetching it, and adding a t() for the Note text.
| @@ -29,14 +29,19 @@ const noteFormSchema = z.object({ | |||
|
|
|||
| interface PatientNotesFormProps extends DefaultWorkspaceProps { | |||
| patientUuid: PatientUuid; | |||
| emrConfiguration: EmrApiConfigurationResponse; | |||
| isLoadingEmrConfiguration: boolean; | |||
| errorFetchingEmrConfiguration: Error; | |||
There was a problem hiding this comment.
Is there a reason you moved this from using to useEmrConfiguration to pass in as a prop? I think SWR is smart enough to cache this request instead of making it multiple times, it seems clearer to just have useEmrConfiguration each time you need that resource. @chibongho?
There was a problem hiding this comment.
Right, will revert this. Thanks @mogoodrich
| return ( | ||
| <Tile className={styles.noteTile}> | ||
| <div className={styles.noteHeader}> | ||
| <span className={styles.noteProviderRole}>Note</span> |
There was a problem hiding this comment.
Thanks for changing this to "Note". Let's use a t() here to translate this.
| 'encounterRole:(uuid,display),' + | ||
| 'provider:(uuid,person:(uuid,display))),' + | ||
| 'diagnoses'; | ||
| const encountersApiUrl = `${restBaseUrl}/encounter?patient=${patientUuid}&encounterType=${encounterType}&v=${customRepresentation}`; |
There was a problem hiding this comment.
Great... I will add the "visit" limiting factor once the endpoint is ready with it.
|
Merging, thanks! |
Requirements
Summary
Adds notes history section on the ward-inpatient-workspace
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3604
Other