(feat) O3-3247: Add forms for transfer patient and swap bed #1267

vasharma05 · 2024-08-02T08:35:58Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
My work includes tests or is validated by existing tests.

Summary

This PR adds 2 forms for transferring patient to another location or to swap beds.

Screenshots

Related Issue

https://issues.openmrs.org/browse/O3-3247

Other

github-actions · 2024-08-02T08:38:38Z

Size Change: -37.2 kB (-0.62%)

Total Size: 5.95 MB

Filename	Change
`packages/esm-ward-app/dist/23.js`	-29.7 kB (removed)	🏆
`packages/esm-ward-app/dist/526.js`	-13 kB (removed)	🏆
`packages/esm-ward-app/dist/882.js`	-17.3 kB (removed)	🏆

ℹ️ View Unchanged

Filename	Size	Change
`packages/esm-active-visits-app/dist/106.js`	8.63 kB	0 B
`packages/esm-active-visits-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-active-visits-app/dist/255.js`	2.5 kB	0 B
`packages/esm-active-visits-app/dist/271.js`	813 B	0 B
`packages/esm-active-visits-app/dist/316.js`	42.9 kB	0 B
`packages/esm-active-visits-app/dist/319.js`	709 B	0 B
`packages/esm-active-visits-app/dist/382.js`	1.22 kB	0 B
`packages/esm-active-visits-app/dist/443.js`	6.98 kB	0 B
`packages/esm-active-visits-app/dist/460.js`	824 B	0 B
`packages/esm-active-visits-app/dist/574.js`	615 B	0 B
`packages/esm-active-visits-app/dist/6.js`	26.9 kB	0 B
`packages/esm-active-visits-app/dist/635.js`	1.22 kB	0 B
`packages/esm-active-visits-app/dist/644.js`	812 B	0 B
`packages/esm-active-visits-app/dist/725.js`	632 B	0 B
`packages/esm-active-visits-app/dist/729.js`	3.08 kB	0 B
`packages/esm-active-visits-app/dist/757.js`	719 B	0 B
`packages/esm-active-visits-app/dist/784.js`	2.63 kB	0 B
`packages/esm-active-visits-app/dist/788.js`	628 B	0 B
`packages/esm-active-visits-app/dist/807.js`	959 B	0 B
`packages/esm-active-visits-app/dist/833.js`	765 B	0 B
`packages/esm-active-visits-app/dist/879.js`	3.02 kB	0 B
`packages/esm-active-visits-app/dist/966.js`	51.3 kB	0 B
`packages/esm-active-visits-app/dist/967.js`	600 B	0 B
`packages/esm-active-visits-app/dist/main.js`	82.6 kB	0 B
`packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js`	3.33 kB	0 B
`packages/esm-appointments-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-appointments-app/dist/152.js`	259 B	0 B
`packages/esm-appointments-app/dist/23.js`	14.4 kB	0 B
`packages/esm-appointments-app/dist/255.js`	2.51 kB	0 B
`packages/esm-appointments-app/dist/265.js`	1.79 kB	0 B
`packages/esm-appointments-app/dist/271.js`	2.31 kB	0 B
`packages/esm-appointments-app/dist/303.js`	259 B	0 B
`packages/esm-appointments-app/dist/319.js`	2.15 kB	0 B
`packages/esm-appointments-app/dist/460.js`	2.37 kB	0 B
`packages/esm-appointments-app/dist/501.js`	7.02 kB	0 B
`packages/esm-appointments-app/dist/574.js`	1.94 kB	0 B
`packages/esm-appointments-app/dist/581.js`	9.03 kB	0 B
`packages/esm-appointments-app/dist/591.js`	16.8 kB	0 B
`packages/esm-appointments-app/dist/644.js`	2.31 kB	0 B
`packages/esm-appointments-app/dist/646.js`	250 kB	0 B
`packages/esm-appointments-app/dist/729.js`	3.08 kB	0 B
`packages/esm-appointments-app/dist/757.js`	2.19 kB	0 B
`packages/esm-appointments-app/dist/784.js`	2.62 kB	0 B
`packages/esm-appointments-app/dist/788.js`	1.94 kB	0 B
`packages/esm-appointments-app/dist/807.js`	2.56 kB	0 B
`packages/esm-appointments-app/dist/833.js`	2.29 kB	0 B
`packages/esm-appointments-app/dist/85.js`	30.5 kB	0 B
`packages/esm-appointments-app/dist/89.js`	143 kB	0 B
`packages/esm-appointments-app/dist/903.js`	879 B	0 B
`packages/esm-appointments-app/dist/main.js`	410 kB	0 B
`packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js`	3.39 kB	0 B
`packages/esm-bed-management-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-bed-management-app/dist/148.js`	1.22 kB	0 B
`packages/esm-bed-management-app/dist/169.js`	6.98 kB	0 B
`packages/esm-bed-management-app/dist/271.js`	680 B	0 B
`packages/esm-bed-management-app/dist/319.js`	680 B	0 B
`packages/esm-bed-management-app/dist/460.js`	680 B	0 B
`packages/esm-bed-management-app/dist/501.js`	7.03 kB	0 B
`packages/esm-bed-management-app/dist/542.js`	395 B	0 B
`packages/esm-bed-management-app/dist/574.js`	681 B	0 B
`packages/esm-bed-management-app/dist/591.js`	16.8 kB	0 B
`packages/esm-bed-management-app/dist/644.js`	680 B	0 B
`packages/esm-bed-management-app/dist/668.js`	26.5 kB	0 B
`packages/esm-bed-management-app/dist/729.js`	3.08 kB	0 B
`packages/esm-bed-management-app/dist/757.js`	726 B	0 B
`packages/esm-bed-management-app/dist/766.js`	113 kB	0 B
`packages/esm-bed-management-app/dist/784.js`	2.63 kB	0 B
`packages/esm-bed-management-app/dist/788.js`	680 B	0 B
`packages/esm-bed-management-app/dist/805.js`	49.6 kB	0 B
`packages/esm-bed-management-app/dist/807.js`	680 B	0 B
`packages/esm-bed-management-app/dist/833.js`	680 B	0 B
`packages/esm-bed-management-app/dist/main.js`	3.87 kB	0 B
`packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js`	3.25 kB	0 B
`packages/esm-patient-list-management-app/dist/112.js`	73.3 kB	0 B
`packages/esm-patient-list-management-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-patient-list-management-app/dist/255.js`	2.51 kB	0 B
`packages/esm-patient-list-management-app/dist/271.js`	99.8 kB	0 B
`packages/esm-patient-list-management-app/dist/319.js`	1.51 kB	0 B
`packages/esm-patient-list-management-app/dist/37.js`	9.49 kB	0 B
`packages/esm-patient-list-management-app/dist/382.js`	1.23 kB	0 B
`packages/esm-patient-list-management-app/dist/384.js`	1.58 kB	0 B
`packages/esm-patient-list-management-app/dist/443.js`	6.98 kB	0 B
`packages/esm-patient-list-management-app/dist/460.js`	1.72 kB	0 B
`packages/esm-patient-list-management-app/dist/574.js`	1.34 kB	0 B
`packages/esm-patient-list-management-app/dist/591.js`	16.9 kB	0 B
`packages/esm-patient-list-management-app/dist/635.js`	1.23 kB	0 B
`packages/esm-patient-list-management-app/dist/644.js`	1.58 kB	0 B
`packages/esm-patient-list-management-app/dist/729.js`	3.08 kB	0 B
`packages/esm-patient-list-management-app/dist/757.js`	1.51 kB	0 B
`packages/esm-patient-list-management-app/dist/784.js`	2.63 kB	0 B
`packages/esm-patient-list-management-app/dist/788.js`	1.34 kB	0 B
`packages/esm-patient-list-management-app/dist/807.js`	1.85 kB	0 B
`packages/esm-patient-list-management-app/dist/833.js`	1.59 kB	0 B
`packages/esm-patient-list-management-app/dist/main.js`	177 kB	0 B
`packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js`	3.31 kB	0 B
`packages/esm-patient-registration-app/dist/130.js`	317 kB	+2.52 kB (+0.8%)
`packages/esm-patient-registration-app/dist/152.js`	264 B	0 B
`packages/esm-patient-registration-app/dist/169.js`	6.71 kB	0 B
`packages/esm-patient-registration-app/dist/255.js`	2.5 kB	0 B
`packages/esm-patient-registration-app/dist/271.js`	2.13 kB	0 B
`packages/esm-patient-registration-app/dist/290.js`	61.6 kB	0 B
`packages/esm-patient-registration-app/dist/303.js`	264 B	0 B
`packages/esm-patient-registration-app/dist/319.js`	2.05 kB	0 B
`packages/esm-patient-registration-app/dist/371.js`	547 B	0 B
`packages/esm-patient-registration-app/dist/460.js`	2.22 kB	0 B
`packages/esm-patient-registration-app/dist/501.js`	7.03 kB	0 B
`packages/esm-patient-registration-app/dist/540.js`	85 kB	0 B
`packages/esm-patient-registration-app/dist/574.js`	1.78 kB	0 B
`packages/esm-patient-registration-app/dist/591.js`	16.8 kB	0 B
`packages/esm-patient-registration-app/dist/623.js`	7.74 kB	0 B
`packages/esm-patient-registration-app/dist/644.js`	2.13 kB	0 B
`packages/esm-patient-registration-app/dist/729.js`	3.08 kB	0 B
`packages/esm-patient-registration-app/dist/735.js`	465 B	0 B
`packages/esm-patient-registration-app/dist/757.js`	2.15 kB	0 B
`packages/esm-patient-registration-app/dist/784.js`	2.63 kB	0 B
`packages/esm-patient-registration-app/dist/788.js`	1.78 kB	0 B
`packages/esm-patient-registration-app/dist/807.js`	2.51 kB	0 B
`packages/esm-patient-registration-app/dist/833.js`	2.06 kB	0 B
`packages/esm-patient-registration-app/dist/879.js`	3.03 kB	0 B
`packages/esm-patient-registration-app/dist/main.js`	149 kB	0 B
`packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js`	3.35 kB	0 B
`packages/esm-patient-search-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-patient-search-app/dist/255.js`	2.5 kB	0 B
`packages/esm-patient-search-app/dist/271.js`	920 B	0 B
`packages/esm-patient-search-app/dist/319.js`	861 B	0 B
`packages/esm-patient-search-app/dist/382.js`	1.23 kB	0 B
`packages/esm-patient-search-app/dist/420.js`	22.4 kB	0 B
`packages/esm-patient-search-app/dist/443.js`	6.98 kB	0 B
`packages/esm-patient-search-app/dist/460.js`	939 B	0 B
`packages/esm-patient-search-app/dist/574.js`	742 B	0 B
`packages/esm-patient-search-app/dist/591.js`	16.8 kB	0 B
`packages/esm-patient-search-app/dist/634.js`	75.2 kB	0 B
`packages/esm-patient-search-app/dist/635.js`	1.23 kB	0 B
`packages/esm-patient-search-app/dist/644.js`	920 B	0 B
`packages/esm-patient-search-app/dist/729.js`	3.08 kB	0 B
`packages/esm-patient-search-app/dist/757.js`	871 B	0 B
`packages/esm-patient-search-app/dist/784.js`	2.63 kB	0 B
`packages/esm-patient-search-app/dist/788.js`	736 B	0 B
`packages/esm-patient-search-app/dist/807.js`	1.04 kB	0 B
`packages/esm-patient-search-app/dist/833.js`	877 B	0 B
`packages/esm-patient-search-app/dist/main.js`	101 kB	-1 B (0%)
`packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js`	3.3 kB	0 B
`packages/esm-service-queues-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-service-queues-app/dist/152.js`	261 B	0 B
`packages/esm-service-queues-app/dist/169.js`	6.98 kB	0 B
`packages/esm-service-queues-app/dist/186.js`	8.99 kB	0 B
`packages/esm-service-queues-app/dist/199.js`	1.35 kB	0 B
`packages/esm-service-queues-app/dist/236.js`	5.86 kB	0 B
`packages/esm-service-queues-app/dist/255.js`	2.51 kB	0 B
`packages/esm-service-queues-app/dist/265.js`	118 kB	0 B
`packages/esm-service-queues-app/dist/271.js`	4.52 kB	0 B
`packages/esm-service-queues-app/dist/303.js`	261 B	0 B
`packages/esm-service-queues-app/dist/319.js`	3.82 kB	0 B
`packages/esm-service-queues-app/dist/366.js`	7.87 kB	0 B
`packages/esm-service-queues-app/dist/392.js`	7.86 kB	0 B
`packages/esm-service-queues-app/dist/460.js`	4.74 kB	0 B
`packages/esm-service-queues-app/dist/484.js`	158 kB	0 B
`packages/esm-service-queues-app/dist/501.js`	7.03 kB	0 B
`packages/esm-service-queues-app/dist/574.js`	3.85 kB	0 B
`packages/esm-service-queues-app/dist/591.js`	16.8 kB	0 B
`packages/esm-service-queues-app/dist/6.js`	1.75 kB	0 B
`packages/esm-service-queues-app/dist/604.js`	6.98 kB	0 B
`packages/esm-service-queues-app/dist/644.js`	4.53 kB	0 B
`packages/esm-service-queues-app/dist/670.js`	10 kB	0 B
`packages/esm-service-queues-app/dist/727.js`	8.12 kB	0 B
`packages/esm-service-queues-app/dist/729.js`	3.08 kB	0 B
`packages/esm-service-queues-app/dist/752.js`	1.62 kB	0 B
`packages/esm-service-queues-app/dist/757.js`	3.89 kB	0 B
`packages/esm-service-queues-app/dist/760.js`	7.14 kB	0 B
`packages/esm-service-queues-app/dist/784.js`	2.63 kB	0 B
`packages/esm-service-queues-app/dist/788.js`	3.82 kB	0 B
`packages/esm-service-queues-app/dist/800.js`	1.68 kB	0 B
`packages/esm-service-queues-app/dist/807.js`	5.1 kB	0 B
`packages/esm-service-queues-app/dist/818.js`	2.55 kB	0 B
`packages/esm-service-queues-app/dist/828.js`	1.39 kB	0 B
`packages/esm-service-queues-app/dist/833.js`	4.43 kB	0 B
`packages/esm-service-queues-app/dist/911.js`	7.78 kB	0 B
`packages/esm-service-queues-app/dist/940.js`	21.4 kB	0 B
`packages/esm-service-queues-app/dist/main.js`	279 kB	0 B
`packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js`	3.31 kB	0 B
`packages/esm-ward-app/dist/130.js`	317 kB	+2.51 kB (+0.8%)
`packages/esm-ward-app/dist/152.js`	255 B	0 B
`packages/esm-ward-app/dist/169.js`	6.97 kB	0 B
`packages/esm-ward-app/dist/255.js`	2.5 kB	0 B
`packages/esm-ward-app/dist/303.js`	255 B	0 B
`packages/esm-ward-app/dist/348.js`	349 B	0 B
`packages/esm-ward-app/dist/501.js`	7.02 kB	0 B
`packages/esm-ward-app/dist/574.js`	1.28 kB	+243 B (+23.39%)	🚨
`packages/esm-ward-app/dist/577.js`	17.9 kB	0 B
`packages/esm-ward-app/dist/591.js`	16.8 kB	0 B
`packages/esm-ward-app/dist/659.js`	13.4 kB	0 B
`packages/esm-ward-app/dist/725.js`	25 kB	+58 B (+0.23%)
`packages/esm-ward-app/dist/729.js`	3.07 kB	0 B
`packages/esm-ward-app/dist/749.js`	7.89 kB	0 B
`packages/esm-ward-app/dist/767.js`	648 B	0 B
`packages/esm-ward-app/dist/784.js`	2.62 kB	0 B
`packages/esm-ward-app/dist/793.js`	32.1 kB	0 B
`packages/esm-ward-app/dist/803.js`	21.8 kB	0 B
`packages/esm-ward-app/dist/940.js`	21.4 kB	0 B
`packages/esm-ward-app/dist/960.js`	342 B	0 B
`packages/esm-ward-app/dist/999.js`	5.03 kB	0 B
`packages/esm-ward-app/dist/main.js`	60.3 kB	+2.41 kB (+4.17%)
`packages/esm-ward-app/dist/openmrs-esm-ward-app.js`	3.3 kB	+2 B (+0.06%)

_{compressed-size-action}

vasharma05 · 2024-08-08T13:47:35Z

Hi reviewers,
This PR is up for review. Please review the changes.
Thanks!

…ient-management into feat/O3-3247

vasharma05 · 2024-08-08T13:51:20Z

I'll fix the failing tests asap.
Thanks!

mogoodrich

Awesome @vasharma05 ! I had a few small questions/comments, but generally looks good. Would be good to get one other pair of eyes on it before merging, though.

packages/esm-ward-app/src/hooks/useLocations.ts

packages/esm-ward-app/src/location-selector/location-selector.component.tsx

packages/esm-ward-app/src/types/index.ts

...sm-ward-app/src/ward-workspace/patient-transfer-bed-swap/patient-transfer-form.component.tsx

denniskigen

A few minor concerns, but generally LGTM

...sm-ward-app/src/ward-workspace/patient-transfer-bed-swap/patient-transfer-swap.workspace.tsx

packages/esm-ward-app/src/ward-workspace/patient-transfer-bed-swap/patient-transfer-swap.scss

...sm-ward-app/src/ward-workspace/patient-transfer-bed-swap/patient-transfer-form.component.tsx

...sm-ward-app/src/ward-workspace/patient-transfer-bed-swap/patient-bed-swap-form.component.tsx

packages/esm-ward-app/src/root.scss

packages/esm-ward-app/src/location-selector/location-selector.component.tsx

packages/esm-ward-app/src/location-selector/location-selector.scss

vasharma05 · 2024-08-09T12:31:48Z

Hi @denniskigen !
Requesting re-review.
Thanks!

mogoodrich · 2024-08-09T18:32:35Z

...app/src/ward-workspace/patient-transfer-bed-swap/patient-transfer-request-form.component.tsx

+        {
+          concept: emrConfiguration.dispositionDescriptor.internalTransferLocationConcept.uuid,
+          value: values.location,
+        },


(sorry for the slew of comments, deleted the other ones, this is the latest:)

We will make some changes @vasharma05 to support the above. If you are looking to merge before then, can you comment out the above concept/value pair until we add proper support for locations (hopefully early next week)? Thanks!

Hi @mogoodrich, since the locations will not be present, the user will not be able to save the form, I believe it should be alright with the above condition.
Thanks!

…ient-management into feat/O3-3247

Added workspace for bed swapping

8ff5a76

vasharma05 force-pushed the feat/O3-3247 branch from 5b45dbb to 8ff5a76 Compare August 7, 2024 13:57

vasharma05 added 2 commits August 8, 2024 19:14

Completed work on Transfer form

7294839

Update translations

1026590

vasharma05 changed the title ~~(feat) O3-3247: Add forms for transfer patient or swap bed~~ (feat) O3-3247: Add forms for transfer patient and swap bed Aug 8, 2024

vasharma05 marked this pull request as ready for review August 8, 2024 13:46

Bump framework

1ed177e

Merge branch 'main' of https://www.github.com/openmrs/openmrs-esm-pat…

1870a11

…ient-management into feat/O3-3247

mogoodrich approved these changes Aug 8, 2024

View reviewed changes

denniskigen reviewed Aug 8, 2024

View reviewed changes

vasharma05 added 4 commits August 9, 2024 17:44

Final changes

fc3b354

Update translations

1378afe

Review changes

c1a7ee7

Update failing test

170c25c

vasharma05 requested a review from denniskigen August 9, 2024 12:31

mogoodrich reviewed Aug 9, 2024

View reviewed changes

vasharma05 added 4 commits August 12, 2024 10:31

Fix the value prop for radio button group

3694e0a

Fix the workspace name for patient card

b49ebb4

Merge branch 'main' of https://www.github.com/openmrs/openmrs-esm-pat…

b0428a3

…ient-management into feat/O3-3247

Add custom rep to fetch location tag name and other fixes

e4a9280

vasharma05 merged commit 5c274b0 into main Aug 12, 2024
6 checks passed

vasharma05 deleted the feat/O3-3247 branch August 12, 2024 06:02

denniskigen mentioned this pull request Aug 29, 2024

(chore) Release v8.0.0 #1299

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(feat) O3-3247: Add forms for transfer patient and swap bed #1267

(feat) O3-3247: Add forms for transfer patient and swap bed #1267

vasharma05 commented Aug 2, 2024 •

edited by denniskigen

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

vasharma05 commented Aug 8, 2024

vasharma05 commented Aug 8, 2024

mogoodrich left a comment

denniskigen left a comment

vasharma05 commented Aug 9, 2024

mogoodrich Aug 9, 2024

vasharma05 Aug 12, 2024

(feat) O3-3247: Add forms for transfer patient and swap bed #1267

(feat) O3-3247: Add forms for transfer patient and swap bed #1267

Conversation

vasharma05 commented Aug 2, 2024 • edited by denniskigen Loading

Requirements

Summary

Screenshots

Related Issue

Other

github-actions bot commented Aug 2, 2024 • edited Loading

vasharma05 commented Aug 8, 2024

vasharma05 commented Aug 8, 2024

mogoodrich left a comment

Choose a reason for hiding this comment

denniskigen left a comment

Choose a reason for hiding this comment

vasharma05 commented Aug 9, 2024

mogoodrich Aug 9, 2024

Choose a reason for hiding this comment

vasharma05 Aug 12, 2024

Choose a reason for hiding this comment

vasharma05 commented Aug 2, 2024 •

edited by denniskigen

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading