Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) O3-3677: Implement ability to add patient to a queue from lab app #1258

Merged
merged 23 commits into from
Sep 15, 2024
Merged

(feat) O3-3677: Implement ability to add patient to a queue from lab app #1258

merged 23 commits into from
Sep 15, 2024

Conversation

its-kios09
Copy link
Contributor

@its-kios09 its-kios09 commented Jul 29, 2024 •
edited
Loading

…queue from complete lab request

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

see:- https://openmrs.atlassian.net/browse/O3-3677

Screenshots

fix

Related Issue

Other

@ojwanganto
Copy link
Contributor

Thanks, @its-kios09. We needed a way to transition patients to a different service point from the lab and the specific use-case was to handle patients whose results are ready and should be reviewed by a clinician. I had thought that we could potentially set the destination queue with details from the previous queue as this would allow easy transitions from the lab back to the clinician. Am not sure if that is even generally acceptable and would love to hear what others think.
Could we change the option label to read something like 'Add to queue' or something close to that?

@its-kios09
Copy link
Contributor Author

Thanks, @its-kios09. We needed a way to transition patients to a different service point from the lab and the specific use-case was to handle patients whose results are ready and should be reviewed by a clinician. I had thought that we could potentially set the destination queue with details from the previous queue as this would allow easy transitions from the lab back to the clinician. Am not sure if that is even generally acceptable and would love to hear what others think. Could we change the option label to read something like 'Add to queue' or something close to that?

@ojwanganto Thanks for the suggestion lemme work on the Retain Previous Queue Details and Renaming of the action label

ojwanganto
ojwanganto requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ojwanganto ojwanganto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @its-kios09. I have left a comment for your attention.

@ojwanganto ojwanganto changed the title O3-3677: Implement enhancement service queue management for sending back patient to queue for complete lab request O3-3677: Implement ability to add patient to a queue from lab app Aug 2, 2024
ojwanganto
ojwanganto previously requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ojwanganto ojwanganto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @its-kios09. I think we can align some file names to match the functionality.

chibongho
chibongho reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend minor renames. Looks good otherwise.

packages/esm-service-queues-app/src/config-schema.ts Outdated Show resolved Hide resolved
...ice-queues-app/src/transition-latest-queue-entry/transition-latest-queue-entry.component.tsx Outdated Show resolved Hide resolved
packages/esm-service-queues-app/src/index.ts Outdated Show resolved Hide resolved
packages/esm-service-queues-app/translations/en.json Show resolved Hide resolved
packages/esm-service-queues-app/src/index.ts Outdated Show resolved Hide resolved
packages/esm-service-queues-app/src/routes.json Outdated Show resolved Hide resolved
@denniskigen denniskigen changed the title O3-3677: Implement ability to add patient to a queue from lab app (feat) O3-3677: Implement ability to add patient to a queue from lab app Aug 8, 2024
@brandones
Copy link
Contributor

@its-kios09 Can you please address the review feedback from @denniskigen ?

@chibongho chibongho self-requested a review August 19, 2024 18:14
@its-kios09
Copy link
Contributor Author

@denniskigen @brandones @mogoodrich Hello, I have updated the hook, i am requesting for your review

@its-kios09 its-kios09 changed the title (feat) O3-3677: Implement ability to add patient to a queue from lab app O3-3677: Implement ability to add patient to a queue from lab app Aug 21, 2024
@mogoodrich
Copy link
Member

fyi @chibongho

@brandones brandones dismissed ojwanganto’s stale review August 22, 2024 15:14

Feedback addressed

@its-kios09
Copy link
Contributor Author

its-kios09 commented Aug 22, 2024 •
edited
Loading

@ojwanganto @mogoodrich @chibongho kindly requesting for final review

chibongho
chibongho approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ojwanganto
ojwanganto reviewed Aug 22, 2024
View reviewed changes
packages/esm-service-queues-app/src/index.ts
@@ -138,6 +138,13 @@ export const addNewQueueServiceWorkspace = getAsyncLifecycle(
moduleName,
},
);
export const transitionPatientToLatestQueue = getAsyncLifecycle(
Copy link
Contributor

@ojwanganto ojwanganto Aug 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this to 'transitionPatientToNewQueue'? @chibongho what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go with the current naming.

@brandones brandones merged commit 07da6a7 into openmrs:main Sep 15, 2024
6 checks passed
@denniskigen denniskigen changed the title O3-3677: Implement ability to add patient to a queue from lab app (feat) O3-3677: Implement ability to add patient to a queue from lab app Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibongho chibongho chibongho approved these changes

@brandones brandones brandones approved these changes

@ojwanganto ojwanganto ojwanganto approved these changes

@mogoodrich mogoodrich Awaiting requested review from mogoodrich

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@its-kios09 @ojwanganto @brandones @mogoodrich @chibongho @denniskigen