(fix) O3-3391: Appointments form should show errors if all fields were left empty #1182

senthil-athiban · 2024-06-10T05:50:55Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
My work includes tests or is validated by existing tests.

Summary

This PR addresses the issue of not displaying an error message when the user has not filled out the form.

Screenshots

https://www.loom.com/share/932df3a24576492c90a8871a37b156c7

Related Issue

https://openmrs.atlassian.net/browse/O3-3391

… content is too long (openmrs#1042)

…ed to do so (openmrs#1045)

…mrs#1043) Co-authored-by: Jayasanka Weerasinghe <[email protected]>

…ts ESM (openmrs#1048)

…cked In` (openmrs#1050)

Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Mark Goodrich <[email protected]>

)

…gister appointment workspace correctly (openmrs#1053)

…penmrs#1046) * (fix): Tablet-UI. Making Tablet Service-queues metrics header responsive on tablet mode Signed-off-by: Joshua Murithi <[email protected]> * Fixup --------- Signed-off-by: Joshua Murithi <[email protected]> Co-authored-by: Dennis Kigen <[email protected]>

Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Mark Goodrich <[email protected]>

* Enhanced Monthly Calendar UI for Appointment Scheduler * clicking on a day from within the month to change the appointment date * Localized days in weeks * Removed weekly calendar view on appointment scheduler --------- Co-authored-by: Donald Kibet <[email protected]>

…nd void queue entries (openmrs#1052) * (BREAKGING) O3-2748 service queues - add ability to undo transitions and void queue entries * add tests * minor wording fixup * remove unused imports * change undo transition route per update in backend PR * address PR comments

… things unrelated to patient serach (openmrs#1058)

…penmrs#1057)

…ame or identifier (openmrs#1067)

…as 'Appointment Location' (openmrs#1066)

…penmrs#1069)

…penmrs#1073)

…ts Module Co-authored-by: Mark Goodrich <[email protected]>

…ues (openmrs#1076) * (feat) O3-3025: Add validation in change status modal for service queues * (test) updated test to reflect changes

…mrs#1077)

openmrs#1079) * (feat) O3-3030 - make new queue table support creating new queue entry * fix metrics * address PR comment

…ges in Queue Table (openmrs#1082)

openmrs#1068)

…mrs#1070) Co-authored-by: Dennis Kigen <[email protected]>

* Handle null start date on list details * Removed unnecessary optional chaining --------- Co-authored-by: Dennis Kigen <[email protected]>

…-management

…-management into fix/form-validation

brandones · 2024-08-07T18:17:56Z

Ok, we've got design sign-off for this. @denniskigen or @vasharma05 could you please review when you have a minute? It's a very small change, but I think you guys know the zod & react-hook-form stuff better than I do.

denniskigen · 2024-08-07T18:29:51Z

Why are there 51 commits? Can we whittle them down to just 1.

brandones · 2024-08-07T18:33:33Z

Yeah idk. I even tried the trick where you change the base branch to something else and then back to main. Anyway when we hit "squash and merge" it will just make one commit, so it doesn't actually matter.

packages/esm-appointments-app/src/form/appointments-form.component.tsx

…-management into fix/form-validation

senthil-athiban · 2024-08-08T07:09:19Z

Screen.Recording.2024-08-08.at.12.34.31.PM.mov

packages/esm-appointments-app/src/form/appointments-form.component.tsx

mogoodrich

Generally LGTM, thanks!

denniskigen · 2024-08-08T18:52:27Z

Thanks, @senthil-athiban!

donaldkibet and others added 30 commits April 15, 2024 09:28

(fix) fix typo on recurring appointment label (openmrs#1047)

01a5198

(fix) service queues - make edit queue entry modal body scrollable if…

89cb8f0

… content is too long (openmrs#1042)

(fix) O3-2471 recommended visit type tab should only show if configur…

056b55b

…ed to do so (openmrs#1045)

(fix) service queues - unescape queue name when passed into t() (open…

339fffa

…mrs#1043) Co-authored-by: Jayasanka Weerasinghe <[email protected]>

(refactor) O3-2891: Refactor Patient Appointments ESM into Appointmen…

999d5a3

…ts ESM (openmrs#1048)

(feat) re-use upcomming appointment work to mark appointments as `Che…

e3ad60e

…cked In` (openmrs#1050)

(chore) Update translations from Transifex (openmrs#1011)

c4c705b

Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Mark Goodrich <[email protected]>

(feat) use configured identifier type on appointment table (openmrs#1054

d458fce

)

(fix) add @openmrs/esm-patient-common-lib as peer dependency and re…

22c4ee9

…gister appointment workspace correctly (openmrs#1053)

(chore) Update translations from Transifex (openmrs#1055)

bf17e2f

Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Mark Goodrich <[email protected]>

(chore) O3-2989 service queues - refactor <PatientSearch> to not have…

d262417

… things unrelated to patient serach (openmrs#1058)

(feat) O3-2892: Add Patient-Centric View within the Appointments App (o…

0286521

…penmrs#1057)

O3-2788 (fix) appointments table should correctly search by patient n…

b011d26

…ame or identifier (openmrs#1067)

(fix) O3-3009 Appointment form should limit location to those tagged …

eb8b0e8

…as 'Appointment Location' (openmrs#1066)

(fix) O3-3013 Appointment Form should validate invalid time values (o…

9a4f842

…penmrs#1069)

(fix) O3-3013 appointment time validation should match entire string (o…

6a2d007

…penmrs#1073)

(feature) O3-2930: Add date of birth to patient details in Appointmen…

cfa3ddf

…ts Module Co-authored-by: Mark Goodrich <[email protected]>

(feat) O3-3025: Add validation in change status modal for service que…

070ff34

…ues (openmrs#1076) * (feat) O3-3025: Add validation in change status modal for service queues * (test) updated test to reflect changes

(fix) O3-2748 service queue - fix NPE in undo transition dialog (open…

35e45ee

…mrs#1077)

(fix) Fix queue filtering by location (openmrs#1078)

b255b06

(chore) Separate linting and formatting concerns (openmrs#1080)

9c8ddd5

(feat) O3-3030 - make new queue table support creating new queue entry (

6d88d41

openmrs#1079) * (feat) O3-3030 - make new queue table support creating new queue entry * fix metrics * address PR comment

(fix):O3-3039-Fix Incorrect Client Selection Issue When Navigating Pa…

12d4454

…ges in Queue Table (openmrs#1082)

(refactor) O3-3012: Switch registering appointments form workspace ba… (

47e0fad

openmrs#1068)

(fix) Fix error for undifined attribute type (openmrs#1083)

77e9e93

(test) O3-3005: Add E2E test for registering an unknown patient (open…

c58d040

…mrs#1070) Co-authored-by: Dennis Kigen <[email protected]>

(fix) Handle null start date on patient list details (openmrs#1081)

bf2febc

* Handle null start date on list details * Removed unnecessary optional chaining --------- Co-authored-by: Dennis Kigen <[email protected]>

senthil-athiban added 6 commits April 15, 2024 09:29

Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…

549b513

…-management

Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…

67058cf

…-management

Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…

9d449e7

…-management

(fix): improve client side form validation

da79f90

Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…

03fb9b3

…-management into fix/form-validation

Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…

2646c9f

…-management into fix/form-validation

brandones changed the base branch from main to feat/change-patient-list-route July 9, 2024 20:09

brandones changed the base branch from feat/change-patient-list-route to main July 9, 2024 20:10

brandones changed the title ~~fix(O3-3391): enhance client-side form validation~~ fix (O3-3391): Appointments form should show errors if all fields were left empty Jul 9, 2024

brandones requested review from denniskigen and vasharma05 July 24, 2024 15:10

brandones changed the base branch from main to feat/O3-3343 August 7, 2024 18:15

brandones changed the base branch from feat/O3-3343 to main August 7, 2024 18:15

brandones changed the title ~~fix (O3-3391): Appointments form should show errors if all fields were left empty~~ (fix) O3-3391: Appointments form should show errors if all fields were left empty Aug 7, 2024

Merge branch 'main' into fix/form-validation

4482a6a

denniskigen reviewed Aug 7, 2024

View reviewed changes

packages/esm-appointments-app/src/form/appointments-form.component.tsx Show resolved Hide resolved

packages/esm-appointments-app/src/form/appointments-form.component.tsx Outdated Show resolved Hide resolved

senthil-athiban added 2 commits August 8, 2024 12:36

(fix): error validation

15cc2ea

Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…

7c8fd65

…-management into fix/form-validation

denniskigen requested a review from mogoodrich August 8, 2024 14:14

Merge branch 'main' into fix/form-validation

05e113d

denniskigen reviewed Aug 8, 2024

View reviewed changes

packages/esm-appointments-app/src/form/appointments-form.component.tsx Outdated Show resolved Hide resolved

Fixup

d165946

mogoodrich approved these changes Aug 8, 2024

View reviewed changes

denniskigen merged commit 3d055b0 into openmrs:main Aug 8, 2024
6 checks passed

denniskigen mentioned this pull request Aug 29, 2024

(chore) Release v8.0.0 #1299

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(fix) O3-3391: Appointments form should show errors if all fields were left empty #1182

(fix) O3-3391: Appointments form should show errors if all fields were left empty #1182

senthil-athiban commented Jun 10, 2024

brandones commented Aug 7, 2024

denniskigen commented Aug 7, 2024 •

edited

Loading

brandones commented Aug 7, 2024

senthil-athiban commented Aug 8, 2024

mogoodrich left a comment

denniskigen commented Aug 8, 2024 •

edited

Loading

(fix) O3-3391: Appointments form should show errors if all fields were left empty #1182

(fix) O3-3391: Appointments form should show errors if all fields were left empty #1182

Conversation

senthil-athiban commented Jun 10, 2024

Requirements

Summary

Screenshots

Related Issue

brandones commented Aug 7, 2024

denniskigen commented Aug 7, 2024 • edited Loading

brandones commented Aug 7, 2024

senthil-athiban commented Aug 8, 2024

mogoodrich left a comment

Choose a reason for hiding this comment

denniskigen commented Aug 8, 2024 • edited Loading

denniskigen commented Aug 7, 2024 •

edited

Loading

denniskigen commented Aug 8, 2024 •

edited

Loading