Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-3618: Prevent submitting empty lab results form #79

Merged
merged 2 commits into from
Aug 17, 2024
Merged

(fix) O3-3618: Prevent submitting empty lab results form #79

merged 2 commits into from
Aug 17, 2024

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Jul 24, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I fixed the validation using Zod so that the system displays a prominent message indicating missing required fields, with these fields highlighted in red for better visibility.

Screenshots

screencast.2024-08-12.3.PM-46-11.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-3618

Other

@jwnasambu jwnasambu marked this pull request as draft July 24, 2024 19:47
@jwnasambu jwnasambu force-pushed the (fix)O3-3618 branch 6 times, most recently from 8e472ec to 478d953 Compare July 31, 2024 11:17
@jwnasambu jwnasambu force-pushed the (fix)O3-3618 branch 3 times, most recently from 3778b1b to 0dd13d3 Compare August 2, 2024 13:51
@jwnasambu jwnasambu changed the title (fix)O3-3618: Required Field Message Alert for Labs is Not Clear and … (fix)O3-3618: Required Field Message Alert for Labs is Not Clear and is Not Noticeable Aug 2, 2024
@jwnasambu jwnasambu marked this pull request as ready for review August 2, 2024 13:58
@denniskigen
Copy link
Member

I've started a discussion on the approach here

@jwnasambu jwnasambu marked this pull request as draft August 8, 2024 16:42
@jwnasambu jwnasambu force-pushed the (fix)O3-3618 branch 2 times, most recently from 41f1411 to 847841c Compare August 12, 2024 09:30
@denniskigen denniskigen changed the title (fix)O3-3618: Required Field Message Alert for Labs is Not Clear and is Not Noticeable (fix) O3-3618: Validate against submitting empty lab results form Aug 12, 2024
@denniskigen denniskigen changed the title (fix) O3-3618: Validate against submitting empty lab results form (fix) O3-3618: Prevent submission of empty lab results form Aug 12, 2024
@jwnasambu jwnasambu marked this pull request as ready for review August 13, 2024 10:05
@jwnasambu jwnasambu marked this pull request as draft August 13, 2024 10:05
@jwnasambu jwnasambu marked this pull request as ready for review August 13, 2024 15:25
@denniskigen denniskigen changed the title (fix) O3-3618: Prevent submission of empty lab results form (fix) O3-3618: Prevent submitting empty lab results form Aug 17, 2024
denniskigen
denniskigen approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@denniskigen denniskigen merged commit 78e157e into openmrs:main Aug 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnasambu @denniskigen