Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lab results to lab results encounter #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reagan-meant
Copy link
Contributor

@reagan-meant reagan-meant commented Jul 17, 2024

Requirements

  • [x ] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

https://openmrs.atlassian.net/browse/O3-3565

Screenshots

encorderresult

Related Issue

Other

@reagan-meant reagan-meant marked this pull request as ready for review July 18, 2024 19:27
obsPayload: any,
orderPayload: any,
encounterPostData: any
) {
const abortController = new AbortController();

const patientVisits = await openmrsFetch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of fetching all visits and looping through them, it is possible to use the order's encounter and fetch the associated visit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out a way to do that unfortunately.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CynthiaKamau @arodidev could you be of assistance to @reagan-meant

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reagan-meant It should just be: encounters/${encounter.uuid}?v=custom:(visit:(uuid))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out a way to do that unfortunately.

Perhaps you can try exploring that through custom representation

Also kindly address the conflicts

@ibacher
Copy link
Member

ibacher commented Jul 30, 2024

@reagan-meant For all changes, we must have a conventional commit (fix / feat / BREAKING / etc.) and a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants