Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) [O3-3202] Delete Action column #72

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented May 20, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Renames the Action column to Modification

Screenshots

Screenshot 2024-05-20 at 09 32 20

Related Issue

https://openmrs.atlassian.net/browse/O3-3202

Other

@pirupius pirupius self-requested a review May 20, 2024 13:40
@pirupius
Copy link
Member

@Jexsie thanks for the work on this. I've made a comment on the ticket asking Wamz if we really need this column. We might get rid of this entirely.

@Jexsie
Copy link
Contributor Author

Jexsie commented Jun 27, 2024

thanks @pirupius for the review

@Jexsie Jexsie requested a review from pirupius June 27, 2024 15:13
@pirupius pirupius merged commit 235af9a into openmrs:main Jun 28, 2024
3 checks passed
@ojwanganto
Copy link
Contributor

How is this column helpful to the care providers? What does NEW, REVISE, DISCONTINUE mean to them? Do they even understand what this should mean? If we have to show this column then I feel we need to translate these better to avoid confusion. @pirupius @slubwama

@pirupius
Copy link
Member

@ojwanganto that's exactly why this PR's intention changed to delete this column because it didn't add any value. The PR title just wasn't updated

@pirupius pirupius changed the title (fix) [O3-3202] Rename Action column to Modification (fix) [O3-3202] Delete Action column to Modification Jun 29, 2024
@pirupius pirupius changed the title (fix) [O3-3202] Delete Action column to Modification (fix) [O3-3202] Delete Action column Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants