Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U4X-367 : For tests that don’t have ranges, when printing and approving, they don’t show the test results #43

Conversation

jabahum
Copy link
Collaborator

@jabahum jabahum commented Jan 22, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes non-display of Results that are not Set or GroupMembers

Screenshots

before

Screenshot 2024-01-22 at 14 14 31
Screenshot 2024-01-22 at 14 15 35

after

Screenshot 2024-01-22 at 14 11 29
Screenshot 2024-01-22 at 14 10 25

Related Issue

https://metsprogramme.atlassian.net/browse/U4X-367

Other

@jabahum jabahum self-assigned this Jan 22, 2024
@jabahum jabahum changed the title clean up U4X-367 : For tests that don’t have ranges, when printing and approving, they don’t show the test results Jan 22, 2024
@jabahum jabahum requested a review from pirupius January 22, 2024 11:17
@jabahum jabahum marked this pull request as ready for review January 22, 2024 11:17
@jabahum jabahum force-pushed the U4X-367-For-tests-that-don-t-have-ranges-when-printing-and-approving-they-don-t-show-the-test-results branch from 3c3c8c1 to 6cad75e Compare January 22, 2024 13:18
if (isError) return <span>Error</span>;

return (
<span style={{ marginLeft: "10px" }}>{concept?.units ?? "N/A"}</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it posible to move the styles to the styles file?

<tr key={test} style={{ margin: "10px" }}>
<Checkbox
key={index}
style={{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same to this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CynthiaKamau let me look into this

@jabahum jabahum force-pushed the U4X-367-For-tests-that-don-t-have-ranges-when-printing-and-approving-they-don-t-show-the-test-results branch from 17129be to 2aa98c9 Compare January 23, 2024 15:56
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick clean up

package.json Outdated
"extract-translations": "i18next 'src/**/*.component.tsx' --config ./i18next-parser.config.js",
"coverage": "yarn test -- --coverage",
"prepare": "husky install"
"start": "openmrs develop --backend http://194.163.171.253:8282",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think u can remove this ip

Comment on lines 140 to 141
{
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

residue

@pirupius pirupius merged commit 4bcb119 into openmrs:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants