(feat) lab order actions - Add order-actions-slot and switches icons for overflow menu #25
Conversation
| <button | ||
| className={classNames( | ||
| "cds--btn", | ||
| "cds--btn--ghost", | ||
| "cds--overflow-menu__trigger", | ||
| { "cds--overflow-menu--open": showMenu }, | ||
| styles.overflowMenuButton | ||
| )} | ||
| aria-haspopup="true" | ||
| aria-expanded={showMenu} | ||
| id="custom-actions-overflow-menu-trigger" | ||
| aria-controls="custom-actions-overflow-menu" | ||
| onClick={toggleShowMenu} | ||
| > | ||
| {menuTitle} | ||
| </button> | ||
| <div | ||
| className={classNames( | ||
| "cds--overflow-menu-options", | ||
| "cds--overflow-menu--flip", | ||
| styles.menu, |
There was a problem hiding this comment.
Can we switch this to move away from specifying carbon classnames manually? Am sure we can get an equivalent from what comes out of the box.
There was a problem hiding this comment.
thanks @pirupius @jabahum ...
I initially did that and wrapped the OverflowMenuItem items with OverflowMenu out of the box from carbon , which would be the out of the box equivalent but it does not display the extensionSlot which it houses and its children hence on clicking the icon it displays nothing .
So i used the custom overflow flow menu approach that was used in the patient banner actions . Had discussions with Samuel about this, we tested the 2 options and resolved to keep the custom overflow
There was a problem hiding this comment.
@gitcliff i left a comment that you haven't addressed
pirupius
changed the title
pirupius
changed the title
pirupius
changed the title
|
What's pending on this? @gitcliff is there anything else you are working on to complete this work? Thanks |
|
@gitcliff there comments that were previously added but have not been addressed. |
Requirements
Summary
This PR is addressing the issue of adding adding an extension slot under lab order actions to make this more configurable so that implementations can add in whatever custom order actions that suit their needs
Screenshots
Related Issue
Other