Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2724: Move overlays into the framework #201

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

brandones
Copy link
Contributor

DEPENDS ON: openmrs/openmrs-esm-core#979

Requirements

Summary

Creates the space for workspace overlays to be rendered on the home page.

Will need to be fixed up once openmrs/openmrs-esm-core#979 is merged.

Screenshots

workspace-overlay

Related Issue

https://openmrs.atlassian.net/browse/O3-2724

Copy link
Contributor

Size Change: +46.7 kB (+21%) 🚨

Total Size: 269 kB

Filename Size Change
packages/esm-home-app/dist/130.js 219 kB +46.5 kB (+27%) 🚨
ℹ️ View Unchanged
Filename Size Change
packages/esm-home-app/dist/271.js 137 B 0 B
packages/esm-home-app/dist/319.js 132 B 0 B
packages/esm-home-app/dist/460.js 173 B 0 B
packages/esm-home-app/dist/467.js 2.12 kB 0 B
packages/esm-home-app/dist/574.js 171 B 0 B
packages/esm-home-app/dist/62.js 22.1 kB 0 B
packages/esm-home-app/dist/625.js 134 B 0 B
packages/esm-home-app/dist/644.js 137 B 0 B
packages/esm-home-app/dist/656.js 4.02 kB +40 B (+1%)
packages/esm-home-app/dist/757.js 132 B 0 B
packages/esm-home-app/dist/784.js 2.63 kB 0 B
packages/esm-home-app/dist/788.js 2.25 kB +87 B (+4%)
packages/esm-home-app/dist/807.js 144 B 0 B
packages/esm-home-app/dist/833.js 145 B 0 B
packages/esm-home-app/dist/913.js 5.71 kB 0 B
packages/esm-home-app/dist/93.js 231 B 0 B
packages/esm-home-app/dist/main.js 6.26 kB +41 B (+1%)
packages/esm-home-app/dist/openmrs-esm-home-app.js 3.15 kB +1 B (0%)

compressed-size-action

Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really comment on the yarn changes, but LGTM, looking forward to trying this out.

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @brandones!

@denniskigen denniskigen merged commit 5859564 into main May 7, 2024
5 checks passed
@denniskigen denniskigen deleted the O3-2724 branch May 7, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants