Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) O3-2901: Add a page header to the home page #186

Merged
merged 28 commits into from
Apr 17, 2024
Merged

(feat) O3-2901: Add a page header to the home page #186

merged 28 commits into from
Apr 17, 2024

Conversation

arodidev
Copy link
Contributor

@arodidev arodidev commented Feb 27, 2024 •
edited by denniskigen
Loading

Requirements

Summary

This pull request adds a page header to the ref app homepage, similar to the ones in other frontend modules' dashboards eg. service queues, and appointments, as per this ticket whose basis was formed from the conversations on this talk post.

Screenshots

Screenshot 2024-02-27 at 14 48 12

Related Issue

None.

Other

None.

CynthiaKamau
CynthiaKamau reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arodidev for this, is it possible to attach the homepage-header component to the homepage-widgets-slot so that this does not affect anyone who is using the extension?

@arodidev arodidev marked this pull request as ready for review February 29, 2024 07:44
CynthiaKamau
CynthiaKamau reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 , just a few minor comments

packages/esm-home-app/src/homepage-header/homepage-header.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header/homepage-illustration.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/routes.json Show resolved Hide resolved
ibacher
ibacher previously requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arodidev. Sorry that this is a series of persnickety comments, but it's important to get the home page right.

packages/esm-home-app/src/homepage-header/homepage-header.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header/homepage-header.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header/homepage-header.scss Outdated Show resolved Hide resolved
packages/esm-home-app/src/index.ts Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header/homepage-header.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/openmrs-esm-home-schema.ts Outdated Show resolved Hide resolved
@denniskigen denniskigen changed the title (feat) O3-2901: Adding header to the refApp home page (feat) O3-2901: Add a page header to the home page Mar 21, 2024
denniskigen
denniskigen reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, @arodidev. I've left a few suggestions.

packages/esm-home-app/src/homepage-header-date/homepage-header-date.scss Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header/homepage-header.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header/homepage-illustration.component.tsx Outdated Show resolved Hide resolved
packages/esm-home-app/src/openmrs-esm-home-schema.ts Outdated Show resolved Hide resolved
packages/esm-home-app/src/homepage-header-date/homepage-header-date.component.tsx Outdated Show resolved Hide resolved
@arodidev arodidev mentioned this pull request Apr 2, 2024
Merged
3 tasks
@denniskigen
Copy link
Member

Mind resolving the conflicts, @arodidev?

@arodidev
Copy link
Contributor Author

arodidev commented Apr 3, 2024

Mind resolving the conflicts, @arodidev?

Thanks @denniskigen , this is done.

@gracepotma
Copy link
Contributor

@arodidev have you gotten everything you need from reviewers at this time?
As soon as you are ready, please loudly let people like @denniskigen know you're ready for prompt re-review for merging - because if feasible it would be great for us to get this into the next RefApp release being cut this week on April 18th :)

@arodidev
Copy link
Contributor Author

@arodidev have you gotten everything you need from reviewers at this time? As soon as you are ready, please loudly let people like @denniskigen know you're ready for prompt re-review for merging - because if feasible it would be great for us to get this into the next RefApp release being cut this week on April 18th :)

Hi @gracepotma thanks for this, I'll prioritize finishing this and clear out the pending reviews so as to have this out by the cut date this week.

@denniskigen
Copy link
Member

@arodidev I've taken the liberty of pushing a commit that fixes some small details.

@ibacher ibacher dismissed their stale review April 16, 2024 19:40

Changes addressed

denniskigen
denniskigen reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arodidev.

denniskigen

This comment was marked as duplicate.

Sign in to view

@denniskigen denniskigen merged commit 0c06279 into openmrs:main Apr 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius left review comments

@denniskigen denniskigen denniskigen approved these changes

@ibacher ibacher Awaiting requested review from ibacher

@CynthiaKamau CynthiaKamau Awaiting requested review from CynthiaKamau

@mseaton mseaton Awaiting requested review from mseaton

@mogoodrich mogoodrich Awaiting requested review from mogoodrich

@ojwanganto ojwanganto Awaiting requested review from ojwanganto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arodidev @denniskigen @gracepotma @pirupius @CynthiaKamau @ibacher