Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OHRI-1622 Introduce support for UI-select-extended control #85

Merged
merged 4 commits into from
Jul 17, 2023
Merged

OHRI-1622 Introduce support for UI-select-extended control #85

merged 4 commits into from
Jul 17, 2023

Conversation

kajambiya
Copy link
Collaborator

@kajambiya kajambiya commented May 25, 2023 •
edited
Loading

Summary

This PR introduces a search combo box (ui-select-extended) component to the form engine.
The component has been developed in 2 flavours:

  • Preloaded. This is for small datasets where the combo box is loaded with data at initial load
  • Searchable. This is for huge datasets and the data is only loaded when the user starts to type/search the combo box.
Screen.Recording.2023-05-31.at.10.41.28.mov

@pirupius pirupius mentioned this pull request May 29, 2023
Closed
3 tasks
@kajambiya kajambiya force-pushed the 03-2055 branch 2 times, most recently from 577207a to 93f410a Compare May 31, 2023 07:29
@kajambiya kajambiya marked this pull request as ready for review May 31, 2023 08:02
@pirupius pirupius self-requested a review May 31, 2023 08:09
samuelmale
samuelmale requested changes May 31, 2023
View reviewed changes
Copy link
Member

@samuelmale samuelmale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Jovan! A couple of minor early comments.

src/api/types.ts Outdated Show resolved Hide resolved
src/api/types.ts Outdated Show resolved Hide resolved
__mocks__/forms/ohri-forms/external_data_source_form.json Show resolved Hide resolved
src/api/types.ts Outdated Show resolved Hide resolved
src/api/types.ts Outdated Show resolved Hide resolved
src/components/inputs/ui-select-extended/ui-select-extended.tsx Outdated Show resolved Hide resolved
src/components/loaders/inline-loader.component.tsx Outdated Show resolved Hide resolved
src/components/inputs/ui-select-extended/ui-select-extended.tsx Outdated Show resolved Hide resolved
src/submission-handlers/encounterProviderHandler.ts Outdated Show resolved Hide resolved
src/data-sources/concept-provider-data-source.ts Outdated Show resolved Hide resolved
@kajambiya kajambiya changed the title 03-2055 Add Searchable combo box and capturing of encounter provider Add generic search combo box Jun 2, 2023
@gracepotma
Copy link
Contributor

@kajambiya would be great to get this merged in. Seeing that this is 3 weeks old already. I think it looks like we're waiting for your responses to Samuel's comments?

@kajambiya
Copy link
Collaborator Author

@kajambiya would be great to get this merged in. Seeing that this is 3 weeks old already. I think it looks like we're waiting for your responses to Samuel's comments?

Hi @gracepotma, Sorry for my late response. This was overtaken by events(some urgent work with Namibia) and then I went for leave. But now I'm back and this is top on my priority list

@kajambiya kajambiya changed the title Add generic search combo box OHRI-1622 Introduce support for UI-select-extended control Jul 14, 2023
mogoodrich
mogoodrich reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samuelmale for flagging me on this PR. I don't think I currently have the full knowledge/time to review this one in detail, but please do feel free to continue to flag me on form-engine tickets as I hope to get more involved as time goes on, thanks!

@samuelmale samuelmale merged commit d83cf7d into openmrs:main Jul 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogoodrich mogoodrich mogoodrich left review comments

@dkayiwa dkayiwa dkayiwa left review comments

@samuelmale samuelmale samuelmale approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

@donaldkibet donaldkibet Awaiting requested review from donaldkibet

@pirupius pirupius Awaiting requested review from pirupius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kajambiya @gracepotma @mogoodrich @dkayiwa @samuelmale