Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Resolve a bug where a NaN value causes an infinite re-render cycle in the Number input #406

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Oct 3, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Carbon's NumberInput misbehaves when passed a NaN value. This PR addresses this issue by resolving NaN values.

Bug in action:

Screenshot 2024-10-03 at 21 55 10

(The number input fails to render because the calculate expression returns a NaN.)

Screenshots

Fixed:

Screenshot 2024-10-03 at 22 00 50

Related Issue

N/A

Other

Copy link

github-actions bot commented Oct 3, 2024

Size Change: +28 B (0%)

Total Size: 1.18 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 330 kB 0 B
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/422.js 6.8 kB 0 B
dist/501.js 108 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/572.js 252 kB +12 B (0%)
dist/617.js 86.9 kB 0 B
dist/635.js 14.3 kB 0 B
dist/70.js 483 B 0 B
dist/901.js 11.8 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 342 kB +16 B (0%)
dist/openmrs-esm-form-engine-lib.js 3.67 kB 0 B

compressed-size-action

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pirupius pirupius merged commit 5316533 into main Oct 3, 2024
4 checks passed
@pirupius pirupius deleted the fix/numberInput branch October 3, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants