Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fixes to formatDate expression and adds tests for built-in expressions helpers #404

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

pirupius
Copy link
Member

@pirupius pirupius commented Oct 3, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • formatDate expression was actually parsing string to date so the logic has been moved to parseDate (this was introduced as part of AFE parity)
  • formatDate now gives the option to format dates based on locale or a format string
  • Adds custom expression tests and clean up of existing ones

Screenshots

Related Issue

Other

Copy link

github-actions bot commented Oct 3, 2024

Size Change: +30.1 kB (+2.63%)

Total Size: 1.18 MB

Filename Size Change
dist/151.js 330 kB +30.1 kB (+10.04%) ⚠️
ℹ️ View Unchanged
Filename Size Change
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/422.js 6.8 kB 0 B
dist/501.js 108 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/572.js 252 kB -2 B (0%)
dist/617.js 86.9 kB 0 B
dist/635.js 14.3 kB 0 B
dist/70.js 483 B 0 B
dist/901.js 11.8 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 342 kB +42 B (+0.01%)
dist/openmrs-esm-form-engine-lib.js 3.67 kB +1 B (+0.03%)

compressed-size-action

@pirupius pirupius changed the title (fix) Fixes to formatDate expression and adds tests for custom expression helpers (fix) fixes to formatDate expression and adds tests for custom expression helpers Oct 3, 2024
@pirupius pirupius changed the title (fix) fixes to formatDate expression and adds tests for custom expression helpers (fix) fixes to formatDate expression and adds tests for built-in expressions helpers Oct 3, 2024
@samuelmale samuelmale merged commit 7970699 into main Oct 3, 2024
4 checks passed
@samuelmale samuelmale deleted the fix/format-date-helper branch October 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants