(test) O3-3937 Add test coverage around form readonly mode #401
+245
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
samuelmale
reviewed
Sep 25, 2024
src/form-engine.test.tsx
Outdated
Comment on lines
219
to
244
| describe('Read only mode', () => { | ||
| it('should ascertain that each field with readonly = true passed will not be editable', async () => { | ||
| await act(async () => { | ||
| renderForm(null, readOnlyValidationForm); | ||
| }); | ||
|
|
||
| const visitTypeDropdown = screen.getByRole('combobox', { | ||
| name: /visit type/i, | ||
| }); | ||
| const visitPunctualityTextbox = screen.getByLabelText(/visit punctuality/i); | ||
|
|
||
| expect(visitTypeDropdown).toBeInTheDocument(); | ||
| expect(visitTypeDropdown).toHaveClass('cds--list-box__field'); | ||
|
|
||
| const visitTypeWrapper = visitTypeDropdown.closest('.cds--dropdown'); | ||
| expect(visitTypeWrapper).toHaveClass('cds--dropdown cds--dropdown--readonly cds--list-box'); | ||
|
|
||
| expect(visitPunctualityTextbox).toBeInTheDocument(); | ||
| expect(visitPunctualityTextbox).toHaveClass('cds--text-input'); | ||
|
|
||
| const visitPunctualityWrapper = visitPunctualityTextbox.closest('.cds--text-input-wrapper'); | ||
| expect(visitPunctualityWrapper).toHaveClass( | ||
| 'cds--form-item cds--text-input-wrapper cds--text-input-wrapper--readonly', | ||
| ); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I love tests but this test is supposed to be testing a form rendered in "view" mode. I've updated the ticket to clearly reflect this. (sorry for the confusion)
The form-engine supports three major modes: enter (new), edit and view (readonly). This ticket is meant for adding test coverage of the form’s behaviour while in view mode.
There was a problem hiding this comment.
No worries, let me do a rework
CynthiaKamau
force-pushed
the
O3-3937
branch
3 times, most recently
from
de82e10
to
7a498c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
O3-3937 Add test coverage around form readonly mode
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3937
Other