O3 3685: Enable Deleting or Clearing Files in File Picker Component in Edit Mode #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Thanks for working on this @TrevorAntony; Just a few general concerns:
- Is the "delete" operation persistent on form submission? Do we void the complex obs?
- Can you add unit test(s) to assert that the cleared obs gets voided?
|
Having an issue where even after voiding/clearing the obs and successful form submission, when you relaunch the form in edit mode, the cleared image/file is still displayed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Enable Deleting or Clearing Files in File Picker Component in Edit Mode
Summary
When a file is selected using the file picker component and the form is later opened in edit mode, there is now an option to delete or clear the selected file.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3685