(fix) Resolve issue with loading previous values #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending: test coverage |
|
Size Change: -390 B (-0.03%) Total Size: 1.15 MB ℹ️ View Unchanged
|
samuelmale
force-pushed
the
fix/usePreviousValue
branch
from
96d7b16
to
4425b29
Compare
pirupius
approved these changes
Sep 12, 2024
| @@ -62,6 +62,7 @@ const FormEngine = ({ | |||
| const [showSidebar, setShowSidebar] = useState(false); | |||
| const [isSubmitting, setIsSubmitting] = useState(false); | |||
| const [isFormDirty, setIsFormDirty] = useState(false); | |||
| const sessionMode = !isEmpty(mode) ? mode : !isEmpty(encounterUUID) ? 'edit' : 'enter'; | |||
Those changes are necessary for date specific fields. They are basically about formatting the previous date value. |
usamaidrsk
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
For some reason the workspace no longer provides the "session mode" details to the root component. As result, we end up with an
undefined"session mode" value which causes side effects like the "use previous value" feature not working. This PR ensures we infer the session mode in such scenarios. It the obs adapter to ensure that we properly format the date object to a display string.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3918
Other