Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Add hide expression condition for workplace-launcher #376

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jnsereko
Copy link
Contributor

@jnsereko jnsereko commented Sep 6, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This adds condition to hide the workplace launcher button if the hide expression is true. Currently the hideExpression doesn't work for workplace launcher fields. This fixes that.

Screenshots

Initial Behaviour

Screenshot 2024-09-06 at 09 50 16

Epected Behaviour

Screen.Recording.2024-09-06.at.09.01.38.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-3910

Other

@jnsereko
Copy link
Contributor Author

jnsereko commented Sep 6, 2024

cc'ing @pirupius @samuelmale

@pirupius pirupius merged commit 68f55d0 into openmrs:main Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants