(fix) Resolve duplicate form registration #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12 B (0%) Total Size: 1.14 MB ℹ️ View Unchanged
|
pirupius
reviewed
Aug 28, 2024
| @@ -83,7 +83,7 @@ export const FormFactoryProvider: React.FC<FormFactoryProviderProps> = ({ | |||
| const registerForm = useCallback((formId: string, context: FormContextProps) => { | |||
| if (!rootForm.current) { | |||
| rootForm.current = context; | |||
| } else { | |||
| } else if (rootForm.current.formJson.name !== formId) { | |||
There was a problem hiding this comment.
Doesn't formId have the uuid of the form? If that's the case then this might be wrong because the comparison seems to be with the form name
There was a problem hiding this comment.
It's currently based on the form name (this was for troubleshooting purposes)
pirupius
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Added a check to the
registerFormfunction to verify if the incoming form is not already set as the root form.Screenshots
N/A
Related Issue
https://openmrs.atlassian.net/browse/O3-3882
Other