Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) fix post submission action error, improve post submission error handling #144

Merged
merged 1 commit into from
Nov 15, 2023
Merged

(fix) fix post submission action error, improve post submission error handling #144

merged 1 commit into from
Nov 15, 2023

Conversation

kajambiya
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • This PR fixes the error that was being thrown when processing the post submission action.
  • It also improves post submission action error handling so that it throws more meaningful errors.

Screenshots

Screenshot 2023-11-14 at 14 59 51

Related Issue

Other

eudson
eudson requested changes Nov 14, 2023
View reviewed changes
src/ohri-form.component.tsx Outdated Show resolved Hide resolved
src/ohri-form.component.tsx Show resolved Hide resolved
pirupius
pirupius approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kajambiya

src/components/encounter/ohri-encounter-form.component.tsx Show resolved Hide resolved
@pirupius pirupius merged commit 3fec8dd into openmrs:main Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eudson eudson eudson requested changes

@pirupius pirupius pirupius approved these changes

@samuelmale samuelmale Awaiting requested review from samuelmale

@ebambo ebambo Awaiting requested review from ebambo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kajambiya @eudson @pirupius