(feat) Form validator built into interactive form builder #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
requested changes
Aug 1, 2023
src/components/interactive-builder/interactive-builder.component.tsx
Outdated
Show resolved
Hide resolved
src/components/interactive-builder/interactive-builder.component.tsx
Outdated
Show resolved
Hide resolved
ebambo
reviewed
Aug 1, 2023
src/components/interactive-builder/interactive-builder.component.tsx
Outdated
Show resolved
Hide resolved
ebambo
reviewed
Aug 4, 2023
samuelmale
reviewed
Aug 9, 2023
src/components/interactive-builder/interactive-builder.component.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
73
to
78
| const validateForm = () => { | ||
| handleFormValidation(schema).then(response => { | ||
| const [questionResolutionsArray, answersResolutionsArray] = response | ||
| setResponses(questionResolutionsArray) | ||
| }) | ||
| } |
There was a problem hiding this comment.
One other way of injecting the validator would be through a hook:
// the validator runs if doValidate is set to true
// isValidating shows the validation status
const { errors, warnings, isValidating } = useSchemaValidationResults(doValidate, schema);
|
@arodidev FYI: All the checks are failing |
…penmrs-esm-form-builder into feat/schema-validator
|
@arodidev Did you see the build failure |
added 2 commits
August 14, 2023 11:50
commit 3315b3a Author: arodidev <[email protected]> Date: Mon Aug 14 13:32:46 2023 +0300 Moved validation state to parent component
samuelmale
reviewed
Aug 15, 2023
| @@ -163,6 +168,7 @@ const FormEditor: React.FC = () => { | |||
| schema={schema} | |||
| onSchemaChange={updateSchema} | |||
| isLoading={isLoadingFormOrSchema} | |||
| validateStateSetter={validationSetter} | |||
There was a problem hiding this comment.
Suggested change
| validateStateSetter={validationSetter} | |
| validateStateSetter={setIsValidating} |
There was a problem hiding this comment.
Actually, I would rename validateStateSetter to setIsValidating
There was a problem hiding this comment.
The issues cited have been resolved, kindly review @samuelmale
samuelmale
reviewed
Aug 15, 2023
|
@denniskigen can you kindly have a look at this? |
denniskigen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A validation tool that validates whether forms have UUIDS, checks for concepts used the in forms in the backend using the concept UUID or concept mappings provided in the form, and validates whether the datatype on the concepts align with the control type assigned in the form.
Screenshots