(fix) Remove uses of externalModuleName in styleguide components #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @Twiineenock |
|
Size Change: -80.7 kB (-1.43%) Total Size: 5.57 MB
ℹ️ View Unchanged
|
|
Ok. This is not as straightforward as I first thought. Frontend modules that reuse the
Also, typing that gave me a sense of deja vu, which probably means this was all discussed somewhere in the past. Let me see whether I can look it up. The other bit of context here is that the goal is to fix the failing tests in Patient Management. A less convoluted path to getting that done would be to update the |
Yeah, this is why we did it this way, and how I suggest we keep doing it |
|
The issue with doing away with the We probably should just fix the stub. |
|
Closing as discussed in favour of updating the stub. Thanks, guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR removes uses of
externalModuleNamefrom two components in the styleguide. AFAIK,externalModuleNameis used when you want to load a config schema from a separate frontend module into another. In this case, both components are colocated within the style guide and reference the style guide config schema, so there's no need to useexternalModuleName. Unrelatedly, this exposed an issue with the useConfig stub in the framework mock (which is responsible for the failing tests from this refactor in Patient Management). The stub does not correctly handleexternalModuleNameand fails silently in the test environment when the component under test leveragesexternalModuleName.Screenshots
Related Issue
Other