Skip to content

Commit

Permalink
Merge pull request #1657 from openmeterio/wire-kafka-fix
Browse files Browse the repository at this point in the history
fix: use kafka configuration to create admin client
  • Loading branch information
sagikazarmark authored Oct 11, 2024
2 parents 813cf00 + 4c70110 commit 9d2ee06
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
3 changes: 2 additions & 1 deletion cmd/balance-worker/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion cmd/notification-service/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion cmd/server/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion cmd/sink-worker/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openmeter/app/kafka.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func NewKafkaMetrics(meter metric.Meter) (*kafkametrics.Metrics, error) {
return metrics, nil
}

func NewKafkaAdminClient(conf config.KafkaIngestConfiguration) (*kafka.AdminClient, error) {
func NewKafkaAdminClient(conf config.KafkaConfiguration) (*kafka.AdminClient, error) {
kafkaConfigMap := conf.CreateKafkaConfig()
// NOTE(chrisgacsal): remove 'go.logs.channel.enable' configuration parameter as it is not supported by AdminClient
// and initializing the client fails if this parameter is set.
Expand Down

0 comments on commit 9d2ee06

Please sign in to comment.