Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug Fix: Prevent Material ID Reset During Depletion
This pull request addresses a bug where the IDs of multiple classes, including
openmc.Material
, are reset after performing a depletion, causing conflicts when new materials are created post-depletion. The issue arose due to a blanket ID reset mechanism designed to avoid tally ID warnings, which inadvertently affected all classes inheriting fromIDManagerMixin
, including materials.Changes Introduced:
IDManagerMixin.reset_ids()
: Introduced a new class method that specifically handles the resetting.reset_auto_ids
Method: Adjusted the behavior of thereset_auto_ids
method.OpenMCOperator
Class: Replacedreset_auto_ids
method to only reset tallies ids.This PR resolves the material ID conflict issue and allows the depletion process to run without resetting non-tally IDs.
Fixes #2793
Checklist