Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp CI with dependency and Python caching for efficient installs #3112
base: develop
Are you sure you want to change the base?
Revamp CI with dependency and Python caching for efficient installs #3112
Changes from 23 commits
7509341
1524cf7
1bc8572
ac06042
d7c1bdc
d168428
b572a0e
d2dec2d
dd2f4fb
9a170cd
67a4740
afd5144
8349c8a
41e8f3d
b38e1fa
8dc462c
8877edb
83d41de
57b6388
62c31aa
1e7de1e
faa4883
f43fed5
a5b5a75
2264f3e
cd4d977
36d0ded
f107643
048feeb
652c57c
6e9b941
a35fa53
dd78966
b639169
1897a46
6a1d1c0
6ef06d3
d7714ce
53e9353
f7f32bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to put all the installed dependencies in a single folder, e.g.,
$HOME/dependencies/NJOY2016
. Also, in the case of NJOY (and probably the others), we should just be caching the installed version. Right now, the cache for NJOY is 1 GB when it should be much less.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've trimmed the NJOY repository by ~30% by removing its own NJOY-specific testing suite out of the cache; however, removing the build directory causes issues with the vectfit installation. Aside from NJOY and vectfit, all other of the dependencies at the very least remove their own build directories before caching.
I would like to move all the installed dependencies into a single folder as well; however, I will address that in a future PR since it would take a lot of testing and plenty of commits (and this PR already has enough of those as is!).