-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IUPAC 2013 Abundance Data #2586
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting up these PRs @quantaroo! Other than the line comments below, some test results will likely need to be updated in order to get them passing.
openmc/data/data.py
Outdated
'N15': 0.0037950, 'O16': 0.9975700, 'O17': 0.0003835, | ||
'O18': 0.0020450, 'F19': 1.0, 'Ne20': 0.9048, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not sure what to suggest for the 3-isotope interval cases. What is definitely not acceptable is to have the abundances sum to something other than 1. That leaves the following options:
- Slightly modify a single value so that they sum to unity
- Modify all values the same amount so that they sum to unity (will result in weird values)
- Stick with the "best measurements" for these cases
I lean toward option 1 but would definitely like to hear others thoughts.
Hi @paulromano Here are the fixes I will be working on for the other tests: If you see any other test I missed, let me know. |
@quantaroo I like the idea of putting/taking from the isotope with the largest fraction. Can you go ahead and implement that here along with updating test results? Thanks! |
@paulromano I am waiting for @yrrepy on confirmation for the largest fraction. I am having issues finding the new density to update all the densities in the test in test_material::test_borated_water, in test_model::test_py_lib_attributes, and in test_model::test_deplete. I tried printing the output values out but in the test but the test doesn't print these values out. What are your suggestions? Any thoughts @gridley |
Yesterday, I shared with Juris Meija, one of the authors of IUPAC-2013, our current plans, and he has recommended using the IUPAC delta-zero materials. See attachment. This essentially comes back to, when an interval is present, using IUPAC-2013 col.6 values, except when the delta-zero material differs, which is the case for Li, B, Mg, Si, S, Cl. I suppose we could:
Thoughts? I'm not a fan of IUPAC-2013, the intervals and messiness with selecting from different spaces. Hence the desire to easily default to IUPAC-2009 (NIST). |
Ugh, this really is a mess. The thing I worry about with the delta zero materials is that it's hard to even call it "IUPAC 2013" data at that point since those don't show up in the IUPAC 2013 publication. My inclination would be to either use NUBASE 2020 with the small adjustments discussed or just leaving the abundances as is. |
The delta-zero not being in IUPAC 2013 is odd. |
@yrrepy I can ask the lead author on the NUBASE paper who is a fellow scientist at Argonne. |
@paulromano Any updates from your fellow scientist at Argonne? |
@quantaroo Yes, sorry for the delay. I did finally get a chance to consult with him. He suggested one of the options we had above, which is to arbitrarily set the abundance for one of the isotopes to (100 - sum of others). |
Description
References: #2581, #2585, and #2423
Updated the IUPAC 2013 to reflect the better practice of averaging the isotope abundance intervals of column 9 when the interval is present. Otherwise, the best case value from column 6 is used.
Fixes # (issue)
Updated the values and description.
Checklist