Remove initial dilute nuclides in MicroXS #2579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
dilute_initial
option in theMicroXS.from_model
classmethod (#2568 already removeddilute_initial
elsewhere in the depletion solver). Additionally, I've addednuclides
andreactions
arguments toMicroXS.from_model
that make it easier to customize what nuclides/reactions you want to get microscopic cross sections for. When they are omitted, the behavior defaults to the current behavior where the nuclides/reactions are determined from the depletion chain.Checklist
[ ] I have run clang-format on any C++ source files (if applicable)[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)