-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python source class refactor #2524
Merged
Merged
Changes from 15 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
8615975
Refactor of Python source classes and rename one class. Test outputs …
pshriwise 393fa1b
Updating track output results
pshriwise 22a9727
Updating ncrystal inputs
pshriwise 7d7942b
Renaming SourceBase --> Source and Source --> IndependentSource
pshriwise f6a5626
Adding tests for deprecated parameters.
pshriwise 60ef091
Removing MeshSource class and other small updates.
pshriwise 1fcf9d9
Fixing indentation from name Source --> IndependentSource name change
pshriwise fc18fbf
updating source type
pshriwise 6e2a1d9
Update type value to 'independent' for IndependentSource class
pshriwise 460a412
Correcting class type in dlopen tests and adding a tally so the expec…
pshriwise 5f5c8e8
Updating error type for file, library, parameter attributes and ensur…
pshriwise 5fecafa
Resetting test binaries
pshriwise 4ff3c1b
Updating libmesh regression test inputs
pshriwise 1b7d68d
Filling out docstrings
pshriwise d207cdf
Updating the IO spec
pshriwise 70ee07f
Correcting docs for IndependentSourse type attr value.
pshriwise e363c73
fix typo
pshriwise 0e46280
Apply suggestions from @paulromano
pshriwise c11abe1
Renaming Source to SourceBase
pshriwise 3027d8b
Make populate_xml_element an abstractmethod. Add ValueError for inval…
pshriwise 979e803
Alternative method for protecting misuse of IndependentSource. Always…
pshriwise 56dbe88
Removing old setters. Passing parameters
pshriwise 2516bec
Adding deprecated Source class for bkw compatibility.
pshriwise 798f351
Apply suggestions from @paulromano
pshriwise 265b34d
Updating source energy and test results
pshriwise e40da02
Correcting default getattr behavior and adding a test check
pshriwise 2b2e576
Removing additional IndependentSource parameter. Updating tests to re…
pshriwise 9d2ba25
Updating regression tests expected inputs for explicit particle type …
pshriwise 7b30736
Updating unstructured mesh test inputs
pshriwise b290125
Merge remote-tracking branch 'upstream/develop' into src-refactor
pshriwise 0734546
Updating ncrystal test inputs
pshriwise fa01b54
CI trigger
pshriwise c1d4e91
Formatting dlopen source test code
pshriwise f09505e
Merge remote-tracking branch 'upstream/develop' into src-refactor
pshriwise 19fd7a7
Putting setters back in their places
pshriwise 67d9f0d
Reordering source properties and removing duplicates
pshriwise 1f50bbf
FileSource.file to FileSource.path
pshriwise 9e24f7a
Apply suggestion from @paulromano
pshriwise 8648f3c
Updating docstring and some more tests.
pshriwise f5ebea2
Changing test attribute back
pshriwise a2e09c6
Apply suggestions from @paulromano
pshriwise fe23e7a
Removing duplicate code block and moving setters
pshriwise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files below only have
type='independent'
- either this documentation or those files should change...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other classes use the unique component of the class name as their type, so we should do the same here. Updating that docstring now.