Support for NCrystal material in from_xml_element #2496
Conversation
Added support for NCrystal cfg string in from_xml_element
Fix indent
There was a problem hiding this comment.
Thanks for this fix @nicriz! We definitely overlooked this before.
It would be good to update the ncrystal test (tests/regression_tests/ncrystal/test.py) to make sure we're testing for this.
paulromano return Co-authored-by: Paul Romano <[email protected]>
removed else block after adding return
|
@nicriz Are you able to add/update a test as suggested above? |
|
Hi @paulromano, sorry for the long silence. I need to have a look to the other tests first to understand how to do it properly. Not a strong coder here. |
|
Yes, that sounds like a reasonable test. Alternatively you can just compare the Python material objects, the one that you started with and the one that was read back from XML. |
Update NCrystal test.py for cfg string from_xml
PEP8 style guidelines import Co-authored-by: Paul Romano <[email protected]>
blank lines PEP8 Co-authored-by: Paul Romano <[email protected]>
Separate test_cfg_from_xml
Added support for cfg string from ncrystal-generated materials in from_xml_element