276 support on EXCEPTION in CALLs

[AkashKumar7902]

Fixes: #276

[Rune-Christensen]

Thank you for removing the formatting changes, it helps a lot :-D

I would like you to consider if it is possible to tests how mocks work with CALL ON EXCEPTION statements.

And take a look at how the code manages CALL ON EXCEPTION that ends with a period, see my commet.

And if you can find a solution to my comment about the commented call in the resulting code, it would be awesome :-D

[Rune-Christensen]

I think this might break if the "end-call-token" is replaced with a period.

Try making this test:
CALL "PROGRAM" USING DATA-1 ON EXCEPTION
DISPLAY "ERROR".
CALL "PROGRAM" USING DATA-1 ON EXCEPTION
DISPLAY "ERROR".
What code does that result in?
It should look something like this:

• CALL "PROGRAM" USING DATA-1 ON EXCEPTION DISPLAY "ERROR".
• CALL "PROGRAM" USING DATA-1 ON EXCEPTION DISPLAY "ERROR".
  But I think it will concatenate it like this:
• CALL "PROGRAM" USING DATA-1 ON EXCEPTION DISPLAY "ERROR". CALL
• "PROGRAM" USING DATA-1 ON EXCEPTION DISPLAY "ERROR".

[AkashKumar7902]

@Rune-Christensen
Thanks for the question.

The If conditions above line 166 will take care of the period terminator preventing the code from breaking.

The above code is returning the below code:

*CALL "PROGRAM" USING DATA-1 ON EXCEPTION
*    DISPLAY "ERROR"
           CONTINUE                                                            
           .                                                                 
*CALL "PROGRAM" USING DATA-1 ON EXCEPTION
*    DISPLAY "ERROR".                                       
            CONTINUE                                                            
           .

I have also added tests in my new PR :)

Regards,
Akash Kumar

[Rune-Christensen]

I do not like the way that the entire call statement is concatenated into a string, and then split over the required number of lines.
I would prefer that the comment looks something like this, that preserves the original lines and spacing:

* CALL \"PROGRAM\" USING VALUE-1
*   ON EXCEPTION
*   PERFORM 100-WELCOME
* END-CALL.

If you can find an easy fix for that, it would be awesome :-D

[AkashKumar7902]

@Rune-Christensen
Thanks for raising this issue.
I have added code for this in my latest PR.
The commit link is : add pretty format for multiline comment statements

[AkashKumar7902]

@Rune-Christensen
Should the mocked call statement in testfile will have 'on exception' signature ?
like:
MOCK CALL 'PROG' USING VALUE-1
ON EXCEPTION
PERFORM 100-WELCOME
DISPLAY "HELLO WORLD"
END-MOCK

[Rune-Christensen]

@Rune-Christensen Should the mocked call statement in testfile will have 'on exception' signature ? like: MOCK CALL 'PROG' USING VALUE-1 ON EXCEPTION PERFORM 100-WELCOME DISPLAY "HELLO WORLD" END-MOCK

@AkashKumar7902 At the moment, we do not want the MOCK CALL statement, to contain ON EXCEPTION as part of the signature.
Therefore we want to ensure, with a tests, that a call, with on exception, can be mocked and that the mock works. As the code is right now.