304 call mocks are not matching call signatures when one or more program parameters are qualified #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing problem where call mocks can´t find the CALL because the call uses qualified variables. Mock and verify will now find the qualifiers for variables and the arguments can now match CALL´s Signed-off-by: Thomas N. Kramer <[email protected]>
fix, to handle both in and of in a test case Signed-off-by: Thomas N. Kramer <[email protected]>
tests for this cobol check enhancement Signed-off-by: Thomas N. Kramer <[email protected]>
Signed-off-by: Thomas N. Kramer <[email protected]>
dakaa16
previously requested changes
Aug 23, 2023
There was a problem hiding this comment.
I would like some more tests about the arguments. See the test: call_mock_gets_correct_arguments() as an example. A test should exist for arguments with one qualified reference and one with multiple THIS IN SOMETHING IN SOMETHING-ELSE IN ....
I would also like a test for loading in the arguments from the InterpreterController. See it_sets_possible_mock_args() as an example.
Otherwise it looks good 😄
src/test/java/org/openmainframeproject/cobolcheck/TestSuiteParserParsingTest.java
Outdated
Show resolved
Hide resolved
param number \ param type | normal | qualified | test name none covered* - Covered* - one covered* - X verify_can_attach_to_call_mock_with_one_qualified_argument X X verify_call_mock_with_qualified_arguments_mixed two covered* - X verify_can_attach_to_call_mock_with_qualified_arguments X X CALL_MOCK_param_is_qualified_two_but_one three covered* - X CALL_MOCK_param_is_qualified_three X X CALL_MOCK_param_three_is_qualified_three_is_not many (5/6) covered* - X CALL_MOCK_param_six_is_qualified X X CALL_MOCK_param_five_is_qualified_six_is_not * (must be) covered by tests already (I have´nt checked) Signed-off-by: Thomas N. Kramer <[email protected]>
tests have been reworked to use the assertThrows approach. Signed-off-by: Thomas N. Kramer <[email protected]>
The file is generated during a test run, and it contains information about the user Signed-off-by: Thomas N. Kramer <[email protected]>
…obol-check into 304-call-mocks-arent-matching-call-signatures-when-one-or-more-program-parameters-are-qualified � Conflicts: � src/main/java/org/openmainframeproject/cobolcheck/services/cobolLogic/Interpreter.java � src/test/cobol/MOCKTEST/MockCallTest.cut
Rune-Christensen
requested changes
Sep 4, 2023
src/main/java/org/openmainframeproject/cobolcheck/features/testSuiteParser/TestSuiteParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openmainframeproject/cobolcheck/services/cobolLogic/Interpreter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas N. Kramer <[email protected]>
Signed-off-by: Thomas N. Kramer <[email protected]>
Signed-off-by: Thomas N. Kramer <[email protected]>
<TestSuiteParser> uses the new class to hold information about the tokens being parsed. The corresponding unit test has been updated. Signed-off-by: Thomas N. Kramer <[email protected]>
Rune-Christensen
approved these changes
Sep 5, 2023
Rune-Christensen
dismissed
dakaa16’s stale review
The requested changes has been implemented
ThomasNellemann
deleted the
304-call-mocks-arent-matching-call-signatures-when-one-or-more-program-parameters-are-qualified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CALL MOCK and VERIFY CALL will read parameters with qualifiers.
When tests are passed and COBOL is generated, the mocking and verifying is done correctly for CALLs with and without parameters that are written with qualifiers.