Throw an exception no argument #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issacto
force-pushed
the
throw-an-exception-no-argument
branch
from
7ed57de
to
cc321be
Compare
dakaa16
requested changes
Jun 26, 2023
issacto
force-pushed
the
throw-an-exception-no-argument
branch
from
d30456f
to
110129c
Compare
dakaa16
requested changes
Jun 27, 2023
| @@ -133,4 +133,15 @@ public void it_throws_when_no_value_is_passed_for_the_last_argument_and_it_requi | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Hi Issac,
please add another unit test, where it throws the error when you have given arguments, but -p is not there.
There was a problem hiding this comment.
Hey David, I just added the new test case!
Signed-off-by: issacto <[email protected]>
Signed-off-by: issacto <[email protected]>
Signed-off-by: issacto <[email protected]>
Signed-off-by: issacto <[email protected]>
Signed-off-by: issacto <[email protected]>
issacto
force-pushed
the
throw-an-exception-no-argument
branch
from
136e377
to
82c37af
Compare
dakaa16
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.