-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign off #263
Sign off #263
Conversation
Signed-off-by: Samuel <[email protected]>
Hi, So I did a rebase to avoid signing of all my previous commits. Sorry If that is not the best way. Doing a rebase is what I found on stackoverflow. Added functionalities :
example:
TO
example:
TO
TO
|
Signed-off-by: Samuel <[email protected]>
I didn't want to make a instant of reader in the generate class to use readAsOneStatement() that is why I created the getter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sam94dion - Happy new year! :D
There are some minor issues, that I would like you to fix. In addition to that, please do not touch the zip files, as they are the different distribution versions, that are meant for the public to download. These should not be deleted, and a new version should only be added, when a new release is planned.
I apologize for any inconvenience the late reply might cause, and I hope that you are still interested in helping us getting you changes into the next release of cobol check.
src/main/java/org/openmainframeproject/cobolcheck/features/interpreter/CopybookExpander.java
Show resolved
Hide resolved
Hi @dakaa16 I'll get those fixed in a bit :) happy new years to you too. |
Signed-off-by: Samuel <[email protected]>
Done should be better :) |
Hi @sam94dion |
Signed-off-by: Samuel [email protected]