Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign off #263

Closed
wants to merge 3 commits into from
Closed

Sign off #263

wants to merge 3 commits into from

Conversation

sam94dion
Copy link

Signed-off-by: Samuel [email protected]

Signed-off-by: Samuel <[email protected]>
@sam94dion
Copy link
Author

Hi,

So I did a rebase to avoid signing of all my previous commits. Sorry If that is not the best way. Doing a rebase is what I found on stackoverflow.

Added functionalities :

  1. If you want to test a subprogram but the sub program is passed a linkage section you would want to stub that part for the program to be able to run without dependences.

example:

 LINKAGE SECTION.  
 COPY COPY002.
 PROCEDURE DIVISION.

TO

      * LINKAGE SECTION.
       
       COPY COPY002.

       PROCEDURE DIVISION.
  1. You might declare SQL cursors within your working-section which will need to be stubbed

example:

           EXEC SQL  
              DECLARE NAME-CUR CURSOR FOR  
              SELECT FIRST_NAME, LAST_NAME FROM TEXEM
           END-EXEC.

TO

      *      EXEC SQL  
      *        DECLARE NAME-CUR CURSOR FOR  
      *        SELECT FIRST_NAME, LAST_NAME FROM TEXEM
      *      END-EXEC.
  1. If you have SQL copybook you might want to use the variables within the copybook but discard other information.
    example:
       EXEC SQL INCLUDE TEXEM  END-EXEC.

TO

       01  TEXEM.                                                               
           10 FIRST-NAME           PIC X(10).                                   
           10 LAST-NAME            PIC X(10).                                   
           10 TMS-CREA             PIC X(26).     

Signed-off-by: Samuel <[email protected]>
@sam94dion
Copy link
Author

@dakaa16

I didn't want to make a instant of reader in the generate class to use readAsOneStatement() that is why I created the getter()

Copy link
Collaborator

@dakaa16 dakaa16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sam94dion - Happy new year! :D
There are some minor issues, that I would like you to fix. In addition to that, please do not touch the zip files, as they are the different distribution versions, that are meant for the public to download. These should not be deleted, and a new version should only be added, when a new release is planned.

I apologize for any inconvenience the late reply might cause, and I hope that you are still interested in helping us getting you changes into the next release of cobol check.

.gitignore Show resolved Hide resolved
cobolcheck.cmd Outdated Show resolved Hide resolved
@sam94dion
Copy link
Author

sam94dion commented Jan 5, 2023

Hi @dakaa16 I'll get those fixed in a bit :) happy new years to you too.

@sam94dion
Copy link
Author

Done should be better :)

@Rune-Christensen
Copy link
Collaborator

Hi @sam94dion
These changes were implemented in pull request #278
I am therefore closing this PR.
Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants