Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to jump between steps #218

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Allow to jump between steps #218

merged 2 commits into from
Jun 25, 2024

Conversation

myname4423
Copy link
Contributor

Ⅰ. Describe what this PR does

  1. Enables "Jump" between canary release steps: One can patch the status.CanaryStatus.NextStepIndex to jump between steps
  2. Enable patching the traffic strategy of current step
  3. Introduces a ReleaseManager interface: The canary ReleaseManager has already implemented this interface, paving the way for easy integration of the blue-green release strategy in the future.
  4. Abstracts Strategy-Specific Details: Replaces direct references to canary status and strategy with strategy-agnostic functions. This enhancement lays the groundwork for supporting future blue-green deployments more effectively.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

Signed-off-by: yunbo <[email protected]>

allow jump between steps

Signed-off-by: yunbo <[email protected]>

allow jump among steps

Signed-off-by: yunbo <[email protected]>

safte index check

Signed-off-by: yunbo <[email protected]>

add e2e test for step jump

Signed-off-by: yunbo <[email protected]>

amend: style-agonstic reference for webhook

Signed-off-by: yunbo <[email protected]>

improve existing e2e logic to avoid unexpected behaviour

Signed-off-by: yunbo <[email protected]>

jump: nextStep Index default value from 0 to -1

Signed-off-by: yunbo <[email protected]>

after rebase

Signed-off-by: yunbo <[email protected]>
@myname4423 myname4423 changed the title Allow jumping between steps Allow to jump between steps Jun 13, 2024
@zmberg
Copy link
Member

zmberg commented Jun 25, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Jun 25, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit aa28f4e into openkruise:master Jun 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants