bugfix: Filter rs that are not part of the current Deployement #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @zhengjr9! It looks like this is your first PR to openkruise/rollouts 🎉 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 43.39% 43.40%
=======================================
Files 52 52
Lines 5666 5674 +8
=======================================
+ Hits 2459 2463 +4
- Misses 2784 2786 +2
- Partials 423 425 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@zhengjr9 Have you met this problem ever？ |
veophi
reviewed
Dec 21, 2023
|
The DCO failed. Please |
yes,if i had 2 deploy which they has the same selector in the same namespace,the rollout controller while scale down and up another deploy that i didn't update it.that is the logs when i didn't update this deploy but it have relate a rollout. |
zhengjr9
force-pushed
the
bugfix/select_owner_rs
branch
from
f4562ec
to
df5d596
Compare
veophi
reviewed
Dec 25, 2023
| // select rs owner by current deployment | ||
| ownedRSs := make([]*apps.ReplicaSet, 0) | ||
| for _, rs := range allRSs { | ||
| if rs.DeletionTimestamp.IsZero() { |
There was a problem hiding this comment.
if !rs.DeletionTimestamp.IsZero() {
There was a problem hiding this comment.
sorry,it was a silly mistake
veophi
reviewed
Dec 26, 2023
zhengjr9
force-pushed
the
bugfix/select_owner_rs
branch
2 times, most recently
from
f867f18
to
48c4c8f
Compare
Signed-off-by: zhengjr <[email protected]>
|
zhengjr9
force-pushed
the
bugfix/select_owner_rs
branch
from
48c4c8f
to
4dcbc42
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: veophi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
If the selectors of multiple deployments are the same, subsequent tuner operations will be performed to rs that is not the current deployment, resulting in frequent scale-up and scale -down releases