Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: update rollout status log info #164

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

likakuli
Copy link
Contributor

Ⅰ. Describe what this PR does

update rollout status log info correctly

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 17, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot
Copy link

Welcome @likakuli! It looks like this is your first PR to openkruise/rollouts 🎉

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #164 (4dfc7cd) into master (2986258) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   43.34%   43.34%           
=======================================
  Files          50       50           
  Lines        5373     5373           
=======================================
  Hits         2329     2329           
  Misses       2647     2647           
  Partials      397      397           
Flag Coverage Δ
unittests 43.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/rollout/rollout_status.go 20.96% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@likakuli likakuli force-pushed the clean-updatelog branch 3 times, most recently from 4619592 to 2a61b9d Compare July 17, 2023 11:34
@zmberg
Copy link
Member

zmberg commented Jul 18, 2023

@likakuli Can you git fetch origin and git rebase origin/master, and push -f again?

@likakuli
Copy link
Contributor Author

@likakuli Can you git fetch origin and git rebase origin/master, and push -f again?

rebased, but failed also

@zmberg
Copy link
Member

zmberg commented Aug 15, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Aug 15, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 657c6d8 into openkruise:master Aug 15, 2023
17 checks passed
machine3 pushed a commit to machine3/rollouts that referenced this pull request Nov 14, 2023
Signed-off-by: likakuli <[email protected]>
(cherry picked from commit 657c6d8)
machine3 pushed a commit to machine3/rollouts that referenced this pull request Dec 4, 2023
Signed-off-by: likakuli <[email protected]>
(cherry picked from commit 657c6d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants