Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeql and dependency problem #1748

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

furykerry
Copy link
Member

@furykerry furykerry commented Sep 14, 2024

Ⅰ. Describe what this PR does

  1. solve non-pinned dependency problem (part of Improvement of OpenSSF Scorecard Score #1706)
  2. fix incorrect codeql configuration

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (0d0031a) to head (ca9ded0).
Report is 86 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
+ Coverage   47.91%   49.21%   +1.29%     
==========================================
  Files         162      191      +29     
  Lines       23491    19570    -3921     
==========================================
- Hits        11256     9631    -1625     
+ Misses      11014     8689    -2325     
- Partials     1221     1250      +29     
Flag Coverage Δ
unittests 49.21% <ø> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Sep 18, 2024

/lgtm
/approve

@zmberg zmberg merged commit 7dcdf8d into openkruise:master Sep 18, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants