-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: imagePullJob support Tolerations #1705
base: master
Are you sure you want to change the base?
feat: imagePullJob support Tolerations #1705
Conversation
Welcome @zerunhu! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 47.91% 49.34% +1.42%
==========================================
Files 162 191 +29
Lines 23491 19636 -3855
==========================================
- Hits 11256 9689 -1567
+ Misses 11014 8688 -2326
- Partials 1221 1259 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
While testing E2E, I found that a Node had a Taint added.
Due to the Toleration feature of the imagePullJob, it won't be scheduled, causing the test to fail. I realized that I need to modify a large amount of code in test/e2e/apps/pullimages.go. I hope to get some help on how to make these modifications more effectively. @furykerry |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c699156
to
8da250d
Compare
1d2a405
to
af972e3
Compare
af972e3
to
b683b82
Compare
b683b82
to
a7f922f
Compare
The test has passed. Could you please help review this PR? |
/hold |
900433e
to
014d925
Compare
Hello, I have pulled your latest fix code, and all tests have passed now. Could you please help review the PR again? Since I am a beginner with Kruise, I hope you can provide me with some information on what I should do next. @zmberg |
5d3013f
to
e8eca6f
Compare
Signed-off-by: zerunhu <[email protected]>
e8eca6f
to
cff4e59
Compare
Ⅰ. Describe what this PR does
The ImagePullJob supports a tolerations field to tolerate node taints.
Ⅱ. Does this pull request fix one issue?
#1694
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews