Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog #1495

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Changelog #1495

merged 1 commit into from
Jan 26, 2024

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Jan 26, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/S size/S 10-29 label Jan 26, 2024
furykerry
furykerry reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1ac702) 48.60% compared to head (789d173) 48.62%.

❗ Current head 789d173 differs from pull request most recent head d8603eb. Consider uploading reports for the commit d8603eb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
+ Coverage   48.60%   48.62%   +0.02%     
==========================================
  Files         157      157              
  Lines       22480    22480              
==========================================
+ Hits        10926    10932       +6     
+ Misses      10352    10348       -4     
+ Partials     1202     1200       -2
Flag Coverage Δ
unittests 48.62% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruise-bot kruise-bot removed the lgtm label Jan 26, 2024
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from furykerry by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmberg
Signed-off-by: liheng.zms <[email protected]>
d8603eb 
Signed-off-by: liheng.zms <[email protected]>

Signed-off-by: liheng.zms <[email protected]>

kruise changelog 1.4.1, 1.3.1, 1.5.2

Signed-off-by: liheng.zms <[email protected]>
furykerry
furykerry reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg zmberg merged commit 5421ee7 into openkruise:master Jan 26, 2024
23 of 24 checks passed
@zmberg zmberg deleted the changelog branch March 7, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furykerry furykerry furykerry left review comments

@veophi veophi Awaiting requested review from veophi

Assignees

@furykerry furykerry

Labels
lgtm size/S size/S 10-29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmberg @kruise-bot @furykerry