fix data racing

Signed-off-by: AiRanthem <[email protected]>

pkg/controller/uniteddeployment/uniteddeployment_update.go

@@ -59,7 +59,6 @@ func (r *ReconcileUnitedDeployment) manageSubsets(ud *appsv1alpha1.UnitedDeploym
 		}
 	}
 
-	var newPodCreated = false
 	if len(needUpdate) > 0 {
 		_, updateErr = util.SlowStartBatch(len(needUpdate), slowStartInitialBatchSize, func(index int) error {
 			cell := needUpdate[index]
@@ -74,7 +73,6 @@ func (r *ReconcileUnitedDeployment) manageSubsets(ud *appsv1alpha1.UnitedDeploym
 			if updateSubsetErr != nil {
 				r.recorder.Event(ud.DeepCopy(), corev1.EventTypeWarning, fmt.Sprintf("Failed%s", eventTypeSubsetsUpdate), fmt.Sprintf("Error updating PodSet (%s) %s when updating: %s", subsetType, subset.Name, updateSubsetErr))
 			}
-			newPodCreated = newPodCreated || subset.Spec.Replicas < replicas
 			return updateSubsetErr
 		})
 	}
@@ -84,6 +82,12 @@ func (r *ReconcileUnitedDeployment) manageSubsets(ud *appsv1alpha1.UnitedDeploym
 	} else {
 		// If using an Adaptive scheduling strategy, when the subset is scaled out leading to the creation of new Pods,
 		// future potential scheduling failures need to be checked for rescheduling.
+		var newPodCreated = false
+		for _, cell := range needUpdate {
+			subset := (*nameToSubset)[cell]
+			replicas := nextUpdate[cell].Replicas
+			newPodCreated = newPodCreated || subset.Spec.Replicas < replicas
+		}
 		if strategy := ud.Spec.Topology.ScheduleStrategy; strategy.IsAdaptive() && newPodCreated {
 			durationStore.Push(getUnitedDeploymentKey(ud), strategy.GetRescheduleCriticalDuration())
 		}